Introduce new CLIErrors and use them in the Wrangler type-generation src code#14574
Open
dario-piotrowicz wants to merge 2 commits into
Open
Introduce new CLIErrors and use them in the Wrangler type-generation src code#14574dario-piotrowicz wants to merge 2 commits into
dario-piotrowicz wants to merge 2 commits into
Conversation
🦋 Changeset detectedLatest commit: 05fdabf The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
Changeset Review✅ All changesets look good |
This comment was marked as resolved.
This comment was marked as resolved.
@cloudflare/autoconfig
create-cloudflare
@cloudflare/deploy-helpers
@cloudflare/kv-asset-handler
miniflare
@cloudflare/pages-shared
@cloudflare/unenv-preset
@cloudflare/vite-plugin
@cloudflare/vitest-pool-workers
@cloudflare/workers-auth
@cloudflare/workers-editor-shared
@cloudflare/workers-utils
wrangler
commit: |
370b6a9 to
a44f577
Compare
Contributor
|
Codeowners approval required for this PR:
Show detailed file reviewers
|
Introduce a new errors structure based on the abstract class `CLIError` each of this errors has a human and ai error message and displays the appropriate one based on who invoked Wrangler These errors should be applied across all the Wrangler codebase but that would be a huge undertaking so as an expriment these are being just introduced and applied to the `wrangler types` logic (which is simple and self-contained enough)
a44f577 to
9cfb203
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduce a new errors structure based on the abstract class
CLIErroreach of this errors has a human and ai error message and displays the appropriate one based on who invoked WranglerThese errors should be applied across all the Wrangler codebase but that would be a huge undertaking so as an expriment these are being just introduced and applied to the
wrangler typeslogic (which is simple and self-contained enough)To manually test this change you can run something like:
$ WRANGLER_OUTPUTS_FOR_AGENTS=true npx https://pkg.pr.new/wrangler@14574 types --env-interface="123bad"to see the AI version of the invalid env interface name error
output
to see the human version run the following instead:
$ WRANGLER_OUTPUTS_FOR_AGENTS=false npx https://pkg.pr.new/wrangler@14574 types --env-interface="123bad"output
A picture of a cute animal (not mandatory, but encouraged)