Skip to content

[chrome-devtools-patches] Update Chrome DevTools to M150 (Chrome 150)#14573

Draft
petebacondarwin wants to merge 1 commit into
mainfrom
update-chrome-devtools-m150
Draft

[chrome-devtools-patches] Update Chrome DevTools to M150 (Chrome 150)#14573
petebacondarwin wants to merge 1 commit into
mainfrom
update-chrome-devtools-m150

Conversation

@petebacondarwin

Copy link
Copy Markdown
Contributor

Periodic rebase of our maintained Workers-specific Chrome DevTools patches onto a newer upstream release, aligned with Chrome 150 stable (devtools-frontend commit 1d67dc0dafa344bbd6ca75c124e2d6d9d53074d8, up from b66ecf5b).

This is the DevTools frontend used by wrangler dev and the Workers Playground (see packages/chrome-devtools-patches). All 8 maintained patches were rebased and regenerated; applying the regenerated patch set with git am onto the new base reproduces the rebased tree exactly.

Notable adaptations required by upstream churn:

  • Ping keep-alive (0003): ported to the refactored SessionRouter / CDPConnectionObserver observer model; the ping now uses the typed connection.send("Runtime.getIsolateId", ...) API.
  • Source viewing over the network (0004): the JUST_MY_CODE and AUTHORED_DEPLOYED_GROUPING experiments graduated upstream into the navigator-just-my-code and navigator-group-by-authored settings. We now default those settings to on (in sources-meta.ts) instead of force-enabling experiments (in MainImpl.ts), preserving the previous behaviour.
  • Limit heap profiling modes (0007): ProfilesPanel dropped its profileTypes constructor parameter, so we override the new virtual get profileTypes() getter to expose only the heap-snapshot type.
  • Browser support / CSP (0001): re-applied our entrypoint CSP hash onto upstream's expanded script-src.

Verification status (this is a draft):

  • Done: git am of the regenerated patches applies cleanly onto the new base and reproduces the rebased tree exactly.
  • Pending: local build (make devtools-frontend/out/Default/gen/front_end).
  • Pending: CI preview build (preview:chrome-devtools-patches) and manual smoke test (dark-mode console contrast, ?theme= param, "Cloudflare" sources navigator, network tab with disable-cache/throttling hidden, heap profiling limited to the snapshot type).

  • Tests
    • Tests included/updated
    • Automated tests not possible - manual testing has been completed as follows: this fork has no automated test harness; verification is via git am reproducing the patched tree exactly, a local DevTools build, the CI preview build, and a manual smoke test of the patched behaviours (theme query param, "Cloudflare" sources navigator, network-tab customisations, and heap profiling limited to the snapshot type).
    • Additional testing not necessary because:
  • Public documentation
    • Cloudflare docs PR(s):
    • Documentation not necessary because: internal tooling change — a patch-rebase / version bump of the embedded Chrome DevTools fork with no user-facing API or documented-behaviour changes.

A picture of a cute animal (not mandatory, but encouraged)

@changeset-bot

changeset-bot Bot commented Jul 6, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 1fe8421

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@cloudflare/chrome-devtools-patches Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@petebacondarwin petebacondarwin added preview:chrome-devtools-patches Trigger a devtools preview deploy preview:workers-playground Trigger a workers playground preview deploy labels Jul 6, 2026
@github-project-automation github-project-automation Bot moved this to Untriaged in workers-sdk Jul 6, 2026
@ask-bonk

ask-bonk Bot commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

UnknownError: ProviderInitError

github run

@ask-bonk

ask-bonk Bot commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

@petebacondarwin Bonk workflow failed. Check the logs for details.

View workflow run · To retry, trigger Bonk again.

@github-actions

github-actions Bot commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

✅ All changesets look good

@pkg-pr-new

pkg-pr-new Bot commented Jul 6, 2026

Copy link
Copy Markdown
@cloudflare/autoconfig

npm i https://pkg.pr.new/@cloudflare/autoconfig@14573

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@14573

@cloudflare/deploy-helpers

npm i https://pkg.pr.new/@cloudflare/deploy-helpers@14573

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@14573

miniflare

npm i https://pkg.pr.new/miniflare@14573

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@14573

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@14573

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@14573

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@14573

@cloudflare/workers-auth

npm i https://pkg.pr.new/@cloudflare/workers-auth@14573

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@14573

@cloudflare/workers-utils

npm i https://pkg.pr.new/@cloudflare/workers-utils@14573

wrangler

npm i https://pkg.pr.new/wrangler@14573

commit: 1fe8421

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 3 potential issues.

Open in Devin Review

@@ -60,26 +60,26 @@ index 893ac3533f..937e646ab5 100644
import '../../panels/network/network-meta.js';

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔍 Duplicate network-meta.js import will be present after patch application

Patch 0006 adds import '../../panels/network/network-meta.js'; at line 58, but the context lines at line 60 show this import already exists in the upstream file. After applying the patch, js_app.ts will contain the same side-effect import twice. This is harmless at runtime (JS modules are singletons and only execute once), but it's unnecessary code that suggests the patch was not updated when upstream added this import. This is pre-existing (identical in the old patch version), but since this PR rebases all patches, it's a good opportunity to remove the duplicate line from the patch.

(Refers to lines 58-60)

Open in Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.

@@ -74,8 +61,12 @@ index 64d55d4c14..07972be81f 100644
+ display: 'none',

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔍 CSS rule uses invalid quoted value and comma instead of semicolon

The CSS rule at line 61 reads display: 'none', — this has two problems: (1) CSS property values should not be quoted with single quotes ('none' is not a valid CSS value; it should be none), and (2) the declaration ends with a comma instead of a semicolon. As a result, this rule will be silently ignored by browsers, meaning duplicate .cm-editor elements won't be hidden as intended. This is pre-existing (unchanged from the old patch), but since the patches are being rebased, it's worth fixing.

Open in Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.

Comment thread .changeset/chrome-devtools-update-m150.md Outdated
@petebacondarwin petebacondarwin force-pushed the update-chrome-devtools-m150 branch from 569912c to 0a34f44 Compare July 6, 2026 16:09
@github-actions

github-actions Bot commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

The Wrangler DevTools preview is now live. You can access it directly at: https://1cc95e87-cloudflare-devtools.devprod.workers.dev/js_app

In order to test the DevTools preview in wrangler:

  1. npx wrangler dev.
  2. Hit d to open the DevTools in a fresh browser window.
  3. Paste the DevTools preview URL into the address bar (keeping all existing query parameters), e.g:
- https://devtools.devprod.cloudflare.dev/js_app?theme=systemPreferred&ws=127.0.0.1%3A9229%2Fws&domain=tester&debugger=true
+ https://1cc95e87-cloudflare-devtools.devprod.workers.dev/js_app?theme=systemPreferred&ws=127.0.0.1%3A9229%2Fws&domain=tester&debugger=true

@petebacondarwin petebacondarwin force-pushed the update-chrome-devtools-m150 branch from 0a34f44 to 1fe8421 Compare July 6, 2026 18:06
Comment on lines -98 to -99
+ Root.Runtime.ExperimentName.AUTHORED_DEPLOYED_GROUPING,
+ Root.Runtime.ExperimentName.JUST_MY_CODE,

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No longer needed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

preview:chrome-devtools-patches Trigger a devtools preview deploy preview:workers-playground Trigger a workers playground preview deploy

Projects

Status: Untriaged

Development

Successfully merging this pull request may close these issues.

2 participants