Repository navigation
Conversation
The Version header said 3.12.0, cljr-version said 3.11.3, and the README compatibility table already talks about 4.0.0+. Set both to 4.0.0-snapshot (the convention CIDER uses between releases); the -snapshot suffix gets dropped at the release cut. cljr-version is user-visible - the middleware out-of-sync warning prints it.
The setup instructions only mentioned clojure-mode-hook, so clojure-ts-mode users following them never got clj-refactor-mode enabled.
The dep-slimming and alias removal shipped with the 4.0 work, and the ecukes suite is in fact wired into CI. Add the clojure-ts-mode vetting sweep and the eventual jack-in injection API migration as known work.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three small things spotted while auditing the repo against the CIDER 2.0 release:
The version metadata disagreed with itself (
Version: 3.12.0header,cljr-version"3.11.3") and with the README's 4.0.0+ compatibility table. Both are now4.0.0-snapshot, CIDER-style; the suffix gets dropped at the cut.The setup docs only mentioned
clojure-mode-hook, so clojure-ts-mode users never gotclj-refactor-modeenabled. Now documented.The roadmap still listed work that shipped (dep slimming, alias removal) and claimed the ecukes suite isn't in CI (it is). Marked those done and added two new items: the clojure-ts-mode vetting sweep and the eventual jack-in injection API migration.
The commits are consistent with our contribution guidelines
You've added tests (if possible) to cover your change(s)
The new code is not generating byte compile warnings (run
make compile)All tests are passing (run
make test)You've updated the changelog (if adding/changing user-visible functionality)
You've updated the readme (if adding/changing user-visible functionality)