Conversation
bbatsov
force-pushed
the
fix-repl-buffer-port-suggestions
branch
from
September 10, 2026 08:55
2817f90 to
2d24db4
Compare
cider--running-local-nrepl-paths turned the port into a string with prin1-to-string, which is fine for a number but wraps a string in quotes. Ports read from a REPL buffer were numbers for jack-in and strings for cider-connect; since the port normalization they are always strings, so every suggestion from that source came out as proj:"1234" and was then discarded by the liveness gate, which made the breakage invisible. Normalize the port there instead, and do the same in the server filter, which was the last place still handing out a numeric port.
bbatsov
force-pushed
the
fix-repl-buffer-port-suggestions
branch
from
September 15, 2026 10:35
2d24db4 to
1044bba
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The port of an open REPL buffer went through
prin1-to-string, which quotes a string, so since #4180 made all ports strings every suggestion from that source readproj:"1234"and got dropped by the liveness gate. The other port sources masked it. The server filter also still handed out a numeric port, so it's normalized there too.