Repository navigation
Update for recent Python versions, minor bug fixes - #56
Merged
Merged
Conversation
fghaas
commented
Oct 14, 2026
fghaas
commented
Contributor
- build: Drop Python 3.8-3.10, add 3.13, 3.14
- test: update fenced-code-blocks.html golden file for newer Pygments
- refactor: replace deprecated codecs.open() with builtin open()
- refactor: replace deprecated logging.warn() with logging.warning()
- fix: properly close archive file handle in UploadHelper.upload()
- Drop Python 3.8, 3.9, and 3.10 from the test matrix. - Add Python 3.13 and 3.14. - Clean up the GitLab CI pipeline definition.
Newer Pygments versions wrap whitespace between tokens as <span class="w"> and use literal quotes instead of HTML entities, so the expected HTML output needed to be updated. Assisted-by: opencode/qwen3.6-35b-a3b-fp8
The codecs.open() function is deprecated in Python 3.4+. Replace it with open() using the encoding= keyword argument in olxutils/templates.py and olxutils/helpers.py, and remove the now-unused import. Assisted-by: opencode/qwen3.6-35b-a3b-fp8
The warn() function has been deprecated since Python 3.3. Use warning() instead. Assisted-by: opencode/qwen3.6-35b-a3b-fp8
The file opened via open(self.archive, "rb") was never closed, triggering ResourceWarning. Wrap the request in a "with open()" block so the file is closed after the POST completes. Assisted-by: opencode/qwen3.6-35b-a3b-fp8
mrtmm
approved these changes
Oct 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.