Repository navigation
[fix] AI 댓글 시스템 프롬프트 개선 #123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
안녕하세요. AI 프롬프트 개선 감사합니다.
새로운 프롬프트가 훨씬 구체적이고 상세해서 AI의 응답 품질이 향상될 것 같습니다.
다만, 현재 변경사항은 모든 작곡가에게 동일한 페르소나를 적용하게 되어,
ComposerPersona에 저장된 작곡가별identity,mission,constraintsText값이 무시되는 문제가 있습니다. 이는 "작곡가 캐릭터성이 잘 드러나도록 개선"이라는 PR의 목표와는 다소 거리가 있어 보입니다.기존의 동적인 페르소나 설정을 유지하면서 새로운 프롬프트의 장점을 모두 활용할 수 있도록 아래와 같이 수정하는 것을 제안합니다. 이렇게 하면 공통적인 가이드라인과 작곡가별 개성을 모두 AI에게 전달할 수 있습니다.