Skip to content

Fix promotion calculation - #242

Open
cmoetzing wants to merge 2 commits into
chewiebug:developfrom
cmoetzing:issue-235
Open

Fix promotion calculation#242
cmoetzing wants to merge 2 commits into
chewiebug:developfrom
cmoetzing:issue-235

Conversation

@cmoetzing

Copy link
Copy Markdown

I kept the old calculation as fallback. Removing it fails some Sun JDK6 tests.

@codecov-io

codecov-io commented Jan 27, 2020

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 76.92308% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 70.55%. Comparing base (1075435) to head (a979369).
⚠️ Report is 54 commits behind head on develop.

Files with missing lines Patch % Lines
...java/com/tagtraum/perf/gcviewer/model/GCModel.java 81.81% 0 Missing and 2 partials ⚠️
...perf/gcviewer/imp/DataReaderUnifiedJvmLogging.java 50.00% 0 Missing and 1 partial ⚠️

❌ Your patch check has failed because the patch coverage (76.92%) is below the target coverage (85.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@              Coverage Diff              @@
##             develop     #242      +/-   ##
=============================================
+ Coverage      70.49%   70.55%   +0.05%     
- Complexity      1522     1527       +5     
=============================================
  Files            146      146              
  Lines           8632     8639       +7     
  Branches        1392     1395       +3     
=============================================
+ Hits            6085     6095      +10     
+ Misses          1963     1959       -4     
- Partials         584      585       +1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@cmoetzing

Copy link
Copy Markdown
Author

Why is it that Codacy does not understand wildcard imports?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants