Conversation
`#[cfg(feature = "fluent")]` already excludes the whole `if` block from compilation entirely when the `fluent` feature is off, so the block that remains after conditional compilation can only exist when `fluent` is enabled. In that case `cfg!(feature = "fluent")` inside it will always evaluate to `true`, making the `if cfg!(feature = "fluent")` check redundant: it can never be `false` at the point it's evaluated.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#[cfg(feature = "fluent")]already excludes the wholeifblock from compilation entirely when thefluentfeature is off, so the block that remains after conditional compilation can only exist whenfluentis enabled. In that casecfg!(feature = "fluent")inside it will always evaluate totrue, making theif cfg!(feature = "fluent")check redundant: it can never befalseat the point it's evaluated.