Skip to content

Nested vhs render inside a recording panics with 'use of closed network connection' #761

Description

@conorbronsdon

While recording a demo of vhs itself (a tape whose commands include rendering another tape), the outer render reliably crashes:

panic: write tcp 127.0.0.1:<port>->127.0.0.1:<port>: use of closed network connection

Reproduced twice. It looks like the inner vhs's browser session (go-rod/chromedp) collides with the outer one's connection.

Repro:

  1. inner.tape: any minimal tape (Output inner.gif, one Type/Enter).
  2. outer.tape: Output outer.gif, then Type "vhs inner.tape", Enter, Sleep 10s.
  3. vhs outer.tape → panic above.

Environment: vhs 0.11.0 via winget, Windows 10 (10.0.19045), ttyd via winget, recording shell is WSL Ubuntu 24.04 bash.

Fully understand if nested rendering is out of scope — if so, a graceful error ("vhs is already recording") would beat the panic. Happy to provide the exact tapes or test a patch.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions