Repository navigation
fips: correct legacy provider environment variable name - #4192
Merged
cyphermox merged 2 commits intoOct 13, 2026
Merged
Conversation
The shipped openssl.cnf reads CHAINGUARD_LEGACY_ALLOWED; CHAINGUARD_LEGACY_APPROVED is not read by anything, so setting it does not disable the legacy provider. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
@cyphermox is attempting to deploy a commit to the Chainguard Team on Vercel. A member of the Team first needs to authorize it. |
✅ Deploy Preview for ornate-narwhal-088216 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
xnox
approved these changes
Oct 13, 2026
matthewhelmke
approved these changes
Oct 13, 2026
matthewhelmke
left a comment
matthewhelmke
left a comment
Collaborator
There was a problem hiding this comment.
Thank you for catching this!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[x] Check if this is a typo or other quick fix and ignore the rest :)
Type of change
Correction.
What should this PR do?
The non-approved algorithms page tells readers to set
CHAINGUARD_LEGACY_APPROVED=0to disable the legacy provider. The shippedopenssl.cnf(stereoos/openssl/openssl.cnf,os/openssl-4.0/openssl.cnf) readsCHAINGUARD_LEGACY_ALLOWED; nothing readsCHAINGUARD_LEGACY_APPROVED, so following the page has no effect. Also fixes "uniformally" in the same sentence.The section heading still says "Legacy Approved". It is left as is so the existing
#chainguard-legacy-approved-provider-for-opensslanchor keeps working.How should this PR be tested?
docker run --rm --user root --entrypoint sh cgr.dev/chainguard/python:latest-dev -c 'apk add -q openssl; for v in "" CHAINGUARD_LEGACY_APPROVED=0 CHAINGUARD_LEGACY_ALLOWED=0; do echo "== ${v:-default}"; env $v openssl list -providers | grep -A1 "^ [a-z]"; done'legacyis listed for the default run and forCHAINGUARD_LEGACY_APPROVED=0; onlydefaultremains withCHAINGUARD_LEGACY_ALLOWED=0.🤖 Generated with Claude Code