CFE-3987: Fixed insert_lines prepending to the file instead of to the selected region - #6254
Merged
Merged
Conversation
nickanderson
force-pushed
the
CFE-3987/master
branch
2 times, most recently
from
July 30, 2026 12:37
8db4f03 to
df73500
Compare
…region Prior to this fix, promising content before a selected region would instead insert at the top of the file. While technically still before the region, that was not the intended behavior. Ticket: CFE-3987 Changelog: Title Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
nickanderson
force-pushed
the
CFE-3987/master
branch
from
July 30, 2026 12:44
df73500 to
851a61b
Compare
larsewi
changed the title
larsewi
approved these changes
Jul 30, 2026
Member
Author
|
@cf-bottom jenkins please |
|
Alright, I triggered a build: Jenkins: https://ci.cfengine.com/job/pr-pipeline/14371/ Packages: http://buildcache.cfengine.com/packages/testing-pr/jenkins-pr-pipeline-14371/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the test_soft_fail from the regression test added with the ticket.
Ticket: CFE-3987