Repository navigation
Conversation
Sherlock's collaborative audit and AlexZoid's formal verification run both finish on 74e1646, the v3.3.0 tag, so they describe the released code. BurraSec reviewed the month's diffs leading up to it. Upstreamed from protocol-internal#447.
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three reports for
docs/audits/.2026-09-Sherlock.pdf2026-09-burraSec.pdfsrc/**2026-09-FV.pdfsrc/coreSherlock and the formal verification run both finish on
74e16461c, which is thev3.3.0tag, so they describe the released code. BurraSec reviewed the diffs leading up to it.Findings
Sherlock, two low.
computedAtin the future would block every later update, since the setter only accepts a non-decreasing timestamp.SpokeRegistrynow rejects future timestamps outright.BurraSec, one medium and one low, both in hub asset registration and both now fixed.
HubRegistry.registerAssetnow accepts a repeat registration when it agrees with the decimals already recorded, so a registration made too early can be corrected rather than being permanent.Formal verification continues
2026-08-FV.pdfagainst the newer commit, widening the scene set from the hub side to the spoke and messaging sides:SnapshotQueue,Escrow,EscrowFactoryandMessageDispatcher, plus the linked-core scenes.