Skip to content

op-batcher/op-service: shrink the txmgr seam — capture ChainSigner in the batcher, keep txmgr API identical to upstream #505

Description

@philippecamacho

Shrink the txmgr seam. Since the batcher builds the txmgr config itself, it can capture the ChainSigner right there — then op-service/txmgr/espresso.go (the new SimpleTxManager.Sign/SignTransaction methods) and the runtime type assertion in initChainSigner can be deleted, and txmgr's public API stays identical to upstream, which matters for our rebases. Related: ChainSignerFactoryFromConfig is a near-verbatim copy of SignerFactoryFromConfig, which now has no production callers — we should keep exactly one factory.

Original discussion: #459 (comment)

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions