refactor: extract subtree root computation - #336
Conversation
Signed-off-by: Vladislav Lapin <v.lapin@scalablesolutions.io>
|
The fork workflows are still awaiting maintainer approval (Go, lint, buf, and proto generation). I attempted to approve each workflow run, but GitHub restricts that action to repository admins ( |
There was a problem hiding this comment.
Changes visually look correct to me. One thing before we procced: can we compare the two approaches with a benchmark, since the closure was originally kept inline as a possible optimization. Could you add benchstat before/after numbers for VerifySubtreeRootInclusion (old closure vs. extracted method) to the PR? I expect parity - the recursion is dominated by HashNode/SHA-256 - but let's have the numbers
|
Added a reproducible Command: |
Closes #261
Summary
Testing