Skip to content

build: keep json below 3 for Rails 7 appraisals #151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
RenzoMinelli merged 1 commit into from
Sep 25, 2026
+13 −0
Merged

build: keep json below 3 for Rails 7 appraisals #151

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions Appraisals
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,12 +14,16 @@ end

appraise "rails-7_2" do
gem "rails", "~> 7.2.x"

# ActiveSupport 7.x passes `quirks_mode` to JSON.generate, which json 3 rejects.

@santiagorodriguez96 santiagorodriguez96 Sep 25, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think about pointing to rails/rails#58685 instead? Although that issues is for Rails 8...

@RenzoMinelli RenzoMinelli Sep 25, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That issue is ActiveSupport 8.1 passing a positional hash to JSON.parse, fixed in rails/rails#58601 for 8.1 only. Ours is 7.x passing quirks_mode to JSON.generate, which no Rails issue tracks. The common cause is in json 3.0's changelog: unknown options now raise ArgumentError.

gem "json", "< 3"
end

appraise "rails-7_1" do
gem "rails", "~> 7.1.x"

gem "capybara", "~> 3.39"
gem "json", "< 3"
gem "importmap-rails", "~> 2.0"
gem "pry-byebug", "~> 3.10"
gem "rack", "~> 2.2"
Expand All @@ -37,6 +41,9 @@ appraise "devise-5_0" do
install_if "-> { RUBY_VERSION < \"3.0\" }" do
gem "rack", "~> 2.2"
end
install_if "-> { RUBY_VERSION < \"3.2\" }" do
gem "json", "< 3"
end
gem "rspec-rails", ">= 7.1"
gem "sqlite3", ">= 1.6", "!= 1.7.0", "!= 1.7.1", "!= 1.7.2", "!= 1.7.3"
end
4 changes: 4 additions & 0 deletions gemfiles/devise_5_0.gemfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,4 +23,8 @@ install_if -> { RUBY_VERSION < "3.0" } do
gem "rack", "~> 2.2"
end

install_if -> { RUBY_VERSION < "3.2" } do
gem "json", "< 3"
end

gemspec path: "../"
1 change: 1 addition & 0 deletions gemfiles/rails_7_1.gemfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ gem "rubocop-rails", "~> 2.32"
gem "rubocop-rspec", "~> 3.6"
gem "selenium-webdriver"
gem "sqlite3", "~> 1.7"
gem "json", "< 3"
gem "rack", "~> 2.2"

gemspec path: "../"
1 change: 1 addition & 0 deletions gemfiles/rails_7_2.gemfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,5 +18,6 @@ gem "rubocop-rails", "~> 2.32"
gem "rubocop-rspec", "~> 3.6"
gem "selenium-webdriver"
gem "sqlite3", "~> 2.7"
gem "json", "< 3"

gemspec path: "../"
Loading