Repository navigation
feat: add E2E test coverage for visualization page - #197
Merged
Merged
Conversation
Add Playwright tests with mocked API responses covering: - Song playing state (song card, album grid, progress bar, user controls) - No song playing state (empty message, no playback UI) - Error state (error overlay with reconnect button) - Background layers (gradient, darken, bottom gradient) Also: - Add e2e/fixtures.ts with reusable mock helpers for auth, playback, related albums, and SSE routes - Add webServer config to playwright.config.ts for auto-starting Vite - Consolidate existing app.spec.ts to use shared mock helpers Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
- Add data-testid attributes to SongCard, AlbumGrid, ProgressBar, CoverOverlay, and VisualizationContent elements - Replace CSS class selectors with page.getByTestId() in tests - Add mockEmptyVisualization helper to reduce boilerplate Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
cdtinney
force-pushed
the
feat/e2e-test-coverage
branch
from
April 18, 2026 23:12
d53c01f to
2aa2323
Compare
cdtinney
marked this pull request as ready for review
April 18, 2026 23:13
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
page.route()) covering all visualization states:e2e/fixtures.tswith reusable mock helpers for auth, playback, related albums, and SSEwebServerconfig toplaywright.config.tsso Vite starts automaticallyapp.spec.tsto use shared mock helpersCoverage: 3 existing tests + 4 new visualization tests = 7 total E2E tests
Test plan
pnpm test:e2e— all 7 tests pass🤖 Generated with Claude Code