Skip to content

Change HTTP method strings to uppercase #273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
fitudao3788 wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Change HTTP method strings to uppercase #273

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d2763a6
Change HTTP method strings to uppercase
fitudao3788 Aug 24, 2026
9476ff6
Update HTTP method strings to uppercase
fitudao3788 Aug 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
## [Unreleased]

### Fixed
- Change HTTP method strings to uppercase @fitudao3788

### Added

Expand Down
4 changes: 2 additions & 2 deletions zendriver/core/browser.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -839,10 +839,10 @@ async def get(self, endpoint: str) -> Any:
return await self._request(endpoint)

async def post(self, endpoint: str, data: dict[str, str]) -> Any:
return await self._request(endpoint, method="post", data=data)
return await self._request(endpoint, method="POST", data=data)

async def _request(
self, endpoint: str, method: str = "get", data: dict[str, str] | None = None
self, endpoint: str, method: str = "GET", data: dict[str, str] | None = None
) -> Any:
url = urllib.parse.urljoin(
self.api, f"json/{endpoint}" if endpoint else "/json"
Expand Down