Repository navigation
chore(frontend): remove unused npm dependencies - #399
Conversation
Contributor License Agreement✅ Every human contributor has accepted Cattr CLA version 1. CLA SHA-256: |
|
Important Review skippedReview was skipped as selected files did not have any reviewable changes.
 |
| Layer / File(s) | Summary |
|---|---|
Update debounce imports and dependencies package.json, resources/frontend/core/modules/PlannedTimeReport/views/PlannedTimeReport.vue, resources/frontend/core/modules/ProjectGroups/components/GroupProjects.vue, resources/frontend/core/modules/ProjectGroups/views/ProjectGroups.vue, resources/frontend/core/modules/ProjectReport/views/ProjectReport.vue, resources/frontend/core/modules/TimeUseReport/views/TimeuseReport.vue |
Five components now import debounce from lodash/debounce. The package manifest removes lodash.debounce and other listed dependencies. |
Remove Vue integrations package.json, resources/frontend/core/index.js, resources/frontend/core/sass/app.scss |
The vue-moment import and registration, and the vue-multiselect stylesheet import, were removed. The package manifest also removes both dependencies. |
Priority:
Estimated code review effort: 2 (Simple) | ~10 minutes
Change: Other
Possibly related PRs
- cattr-app/server-application#348: Both PRs change the
compression-webpack-plugindependency entry; one upgrades it and this PR removes it. - cattr-app/server-application#346: Both PRs change the
css-loaderdependency entry; one upgrades it and this PR removes it.
Suggested labels: dependencies, javascript
Suggested reviewers: vermorag
Merge Risk: 
d6f95
-
No actionable build or runtime regression was established, so this cleanup is mergeable.
Pre-merge checks: 
-
Check name Status Explanation Description Check Check skipped - CodeRabbit’s high-level summary is enabled. Title check The title clearly and concisely describes the primary change: removing unused frontend npm dependencies. It also covers the related import updates. Docstring Coverage No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0… Linked Issues check Check skipped because no linked issues were found for this pull request. Out of Scope Changes check Check skipped because no linked issues were found for this pull request. Full details: Docstring Coverage
-
Explanation
No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (5 skipped: 5 unsupported.)
-
Finishing Touches
-
📝 Generate docstrings
-
- Commit to this branch
- Create a new PR
🧪 Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
Drop packages that have no usage outside package.json or are already provided transitively by Laravel Mix: - axios-concurrency, cross-env, laravel-mix-alias: no references - chokidar, compression-webpack-plugin, css-loader: transitive via laravel-mix / laravel-mix-compress (pnpm override kept) - vue-moment: only Vue.use() registration, $moment and filters unused - vue-multiselect: only a CSS import, no .multiselect classes in code - lodash.debounce: imports switched to lodash/debounce `process` is kept: Laravel Mix's legacy node polyfills resolve process/browser.js from the project root. Verified with pnpm install --frozen-lockfile, pnpm lint and pnpm prod in node:24-slim. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
d6f954c to
2295bc3
Compare
Summary
Removes npm packages that have no usage in the frontend or are already provided transitively by Laravel Mix. First PR of the upgrade stack:
feat/laravel-12(#395) is based on this branch.Changes
package.json/pnpm-lock.yaml:axios-concurrency,cross-env,laravel-mix-alias(no references);chokidar,compression-webpack-plugin,css-loader(transitive vialaravel-mix/laravel-mix-compress, the pnpm override is kept);vue-moment(only aVue.use()registration,$momentand its filters are unused);vue-multiselect(only a CSS import, no.multiselectclasses in the code);lodash.debounce(imports switched tolodash/debounce).processis kept on purpose: Laravel Mix's legacy node polyfills resolveprocess/browser.jsfrom the project root.Verification
pnpm install --frozen-lockfile,pnpm lintandpnpm prodinnode:24-slim.🤖 Generated with Claude Code
Summary by CodeRabbit