Resolve Hermit binary from PATH in shell hooks - #587
Open
Noot-tooN wants to merge 3 commits into
Open
Conversation
Noot-tooN
commented
Jul 25, 2026
Comment on lines
+18
to
+19
| - name: Install shells | ||
| run: sudo apt-get install --no-install-recommends fish zsh |
Contributor
Author
There was a problem hiding this comment.
Not sure how the maintainers of this repo would feel about this, but i don't see any proper way to test this feature out without this. 馃槃
Noot-tooN
marked this pull request as ready for review
July 25, 2026 18:05
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
hermitexecutable fromPATHwhen generating Bash, Zsh, and Fish shell hooksWhy
The generated shell-hook configuration assumed Hermit was installed at
$HOME/bin/hermit. Installations managed elsewhere, such as Homebrew at/opt/homebrew/bin/hermit, therefore produced an inactive hook: entering a Hermit environment did not updatePATH, so project tools such asnpxremained unavailable.The hook installer now locates the same
hermitexecutable already available onPATHwhile preserving an explicitly configuredHERMIT_ROOT_BIN.Validation
go test -count=1 ./..../bin/golangci-lint run./bin/lint-shell-scriptsgit diff --check