Conversation
…lly streams under Cards resolved a device role by guessing the device type (Polar, Location Service, Health Service). The SDK keys each measurement by its task control's target device, so a protocol running mobility/health on the phone - or a sensor task with a custom role - was fetched from the wrong stream and came back empty. Derive roles from deployment.expectedDataStreams instead and fetch every role a data type streams under. Also bump carp_webservices to the published 4.4.0 and drop the git override.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Statistics cards resolved a data stream's device role by guessing the device type (Polar, Location Service, Health Service). The SDK keys each measurement by its task control's target device (
SQLiteDataManager.onMeasurement→taskControl.destinationDeviceRoleName ?? phone), so a protocol running mobility/health on the phone, or a sensor with a custom role, was fetched from the wrong stream and backfill came back empty.What
StatisticsViewModel.rolesFor(dataType)derives roles fromdeployment.expectedDataStreams— the same source the writer uses._fetchIntofetches every role a type streams under and concatenates; any failure leaves the card untouched.ViewModel.roleOfand the per-carddeviceRoleNameguesses;HeartRateCardViewModelno longer takes a device type;DataStreamQueryService.fetchrequires the role (no silent phone fallback).carp_webservices→ published^4.4.0, git dependency override dropped.Tests
rolesFortest with a phone + custom-role Polar protocol (replaces the two role-guessing tests).dart analyzeclean,flutter test110/110.