Persist asset class - #1137
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a78d23b7d0
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| id=symbol_table.id, | ||
| active=symbol_table.active, | ||
| blacklist_reason=symbol_table.blacklist_reason, | ||
| asset_class=symbol_table.asset_class, |
There was a problem hiding this comment.
For every add/get/list/edit response, the pinned pybinbot==1.11.15 SymbolModel has no asset_class field and Pydantic silently ignores this unknown keyword, so persisted classifications never reach API clients and cannot be used for strategy routing. Add the field to the shared pybinbot model and bump the dependency before constructing these responses.
AGENTS.md reference: AGENTS.md:L12-L12
Useful? React with 👍 / 👎.
a78d23b to
1bc86bb
Compare
1 participant
TODO