Repository navigation
Bump retrofit to 3.0.0 and release as 1.22.1 - #209
Merged
Merged
Conversation
retrofit.version drives both retrofit and converter-jackson, so this moves the whole HTTP layer to the 3.x line, which is where maintenance now goes. The transitive effect is smaller than it first appears: kotlin-stdlib is already a compile dependency via logging-interceptor (1.8.21), so retrofit 3 upgrades it to 2.1.21 rather than introducing Kotlin to consumers. BaseService exposes retrofit2.Retrofit through getRetrofit(), so consumers using that accessor while pinning retrofit 2 will conflict. Supersedes #201, which proposed the same bump but could not be built - fork PRs do not trigger the workflows here. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
edridudi
force-pushed
the
claude/retrofit3
branch
2 times, most recently
from
September 12, 2026 18:54
c26cce1 to
52e9a39
Compare
edridudi
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes #201, which proposed the same bump but was never built — fork PRs do not trigger the workflows here.
retrofit.versiondrives bothretrofitandconverter-jackson, so this moves the whole HTTP layer to 3.x, not just the converter its title named.The Kotlin question, checked rather than assumed
The obvious objection to retrofit 3 is that it pulls in
kotlin-stdlib. It turns out Kotlin is already there:Before (retrofit 2.11.0)
After (retrofit 3.0.0)
So the change is
kotlin-stdlib1.8.21 → 2.1.21 — an upgrade of something consumers already resolve, not a new dependency on their classpath. Kotlin's stdlib is backward compatible, so a consumer on Kotlin 1.8 is not broken by 2.1 being present.Compatibility note
BaseServiceis annotated@Getter, sogetRetrofit()returnsretrofit2.Retrofitto callers. A consumer using that accessor while pinning retrofit 2 will conflict. Everything else in the public API is unaffected.Testing
Includes the MockWebServer suite from #205, which exercises the Retrofit/OkHttp/Jackson stack directly — success, 4xx/5xx, malformed JSON and the retry loop all behave unchanged on 3.0.0.
Version bumped to
1.22.1inpom.xmland the README (dependency snippets plus a compatibility chart row).🤖 Generated with Claude Code