Do not consume the sequential runner host list - #568
Open
OskarEichler wants to merge 3 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Keep the host list intact when selecting the last sequential host.
Reproduction and verification
Execute a Sequential runner twice using a frozen two-host array. Baseline raises FrozenError; a mutable array loses its final host on each run. Candidate visits both hosts on both calls and preserves the original list.
28e04dc73de911374a23c4fc3fd5ef34012dcd63; installed release is 1.25.1 (e35241b7a3acdf3df4d70442b4a2e69bbcfff155).Breaking changes / compatibility / limitations
No intended breaking changes. Preserve host order, inter-host waits, last-block return value and nil for an empty list. No trailing wait added; parallel runner behavior is untouched.
No production access, real SSH sessions, deployment or concurrency increase.