fix: adjust generation to resolve issues with MTX#325
Conversation
SummaryThe following content is AI-generated and provides a summary of the pull request: Fix: Add After-Deploy Handlers for SQLite and Postgres in MTX ScenariosBug Fix🐛 Resolves multiple deployment failures in multi-tenant (MTX) applications by introducing Additionally fixes HDI deployment failures caused by Changes
Jira Issues
PR Bot InformationVersion:
|
There was a problem hiding this comment.
The PR introduces solid fixes for multi-tenant startup crashes and HDI deployment failures. There are a few substantive issues to address: a potential TypeError from unguarded regex match results in the dropTriggers chain, missing null-guards for mps (ModelProviderService) in both the SQLite and Postgres deployment handlers which would crash on .getCsn(), a data-loss risk from the non-atomic delete+insert of label data, and a misleading comment in the HDI compiler hook around the enhanceModel idempotency behavior.
PR Bot Information
Version: 1.21.0
- Correlation ID:
311b991b-5506-4553-9768-7eded64459cc - Event Trigger:
pull_request.opened - LLM:
anthropic--claude-4.6-sonnet - File Content Strategy: Full file content
Related to #321
cds.xt.DeploymentService.after('deploy')hook so artifacts are deployed against the freshly created tenant schema (skipping thet0metadata tenant)cds.compile.to.sqlruns in parallel and lead to the issue that triggers were registered before the table exist)Changes_CT_INDEX/Changes_CT_parent_INDEX.hdbindexartifacts when the Changes table is in the compiled model (fixesrequires db://SAP_CHANGELOG_CHANGES … not provided by any fileHDI deploy errors)enhanceModelwork onxtendedruntime CSNs (extensibility upgrades)enhanceModelinsidecds.compiler.to.hdi.migrationand oncds.xt.ModelProviderService.{getCsn, getExtCsn}so HANA HDI builds and MPS consumers always see ChangeView (fixesinvalid column name CHANGEVIEW_0.PARENT_ENTITYKEYon upgrades)ensureUndeployJsonHasTriggerPattern()in MTX (no localundeploy.jsonto maintain)