Skip to content

chore: No longer add keys into data for UPDATE and INSERT.entries #1423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
BobdenOs wants to merge 5 commits into
base: main
Choose a base branch
from
+0 −7
Open

chore: No longer add keys into data for UPDATE and INSERT.entries #1423

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
19fd544
Remove fill-in-keys
BobdenOs Nov 18, 2025
a156629
Merge branch 'main' of https://github.com/cap-js/cds-dbs into chore/r…
BobdenOs Jan 15, 2026
e30bbe0
Reduce scope of cleanup
BobdenOs Jan 15, 2026
2f5d15d
Merge branch 'main' into chore/remove-enrich-keys
sjvans Apr 8, 2026
43f8680
Merge branch 'main' into chore/remove-enrich-keys
PDT42 Sep 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 0 additions & 7 deletions db-service/lib/fill-in-keys.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,7 @@
const cds = require('@sap/cds')
const { hasDeep } = require('./deep-queries')

// REVISIT: very deep & fragile dependencies to internal modules -> copy these into here
const propagateForeignKeys = require('@sap/cds/libx/_runtime/common/utils/propagateForeignKeys')
const { enrichDataWithKeysFromWhere } = require('@sap/cds/libx/_runtime/common/utils/keys')

const assoc4 = (e) => e.own('$fk4', ()=> {
const old = e['@odata.foreignKey4']; if (old) return old
Expand Down Expand Up @@ -58,11 +56,6 @@ const generateUUIDandPropagateKeys = (entity, data, event) => {
module.exports = async function fill_in_keys(req, next) {
// REVISIT dummy handler until we have input processing
if (!req.target || !this.model || req.target._unresolved) return next()
// only for deep update
if (req.event === 'UPDATE' && hasDeep(req.query)) {
// REVISIT for deep update we need to inject the keys first
enrichDataWithKeysFromWhere(req.data, req, this)
}

// REVISIT no input processing for INPUT with rows/values
if (!(req.query.INSERT?.rows || req.query.INSERT?.values)) {
Expand Down
Loading