Repository navigation
fix(dashboard): hide empty analysis card from verify-permission holders - #996
Merged
Merged
Conversation
#994 surfaced the dashboard analysis/timeline cards to any holder of the Verify permission so they could reach claims on role-based actions (empty validator list). But the default `member` role carries Verify for the whole community, so every member saw an empty "actions for analysis" card even with nothing to vote on (reported on muda: a regular member suddenly had "access to analyze actions", empty queue). Explicit validators are unchanged — they always see their card. Verify-only holders now see it just when they actually have votable claims waiting (analysis.count > 0), which the dashboard already fetches unconditionally on init. The on-chain signing/voting path is untouched; the contract stays the authority. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Report (muda, 2026-07-07): a regular member ("Cissa") suddenly had "access to analyze actions", with an empty queue — she was never made an approver.
Root cause: #994 surfaced the dashboard analysis/timeline cards to any holder of the Verify permission so they could reach claims on role-based actions (empty validator list). But the default
memberrole carriesverifyfor the entire community:So all 6,966 muda members (and the equivalent in nearly every community) now saw an empty "actions for analysis" card. The only matching pending claims in muda are 2020–2021, filtered by backend #346's 2-year queue cutoff → empty queue.
Fix
analysis.count > 0). The dashboard already fetches available analysis unconditionally on init, so no extra query.On-chain signing/voting path untouched; the contract stays the authority (a verify holder with a stray votable claim still reaches it, and can still vote via direct link regardless).
🤖 Generated with Claude Code