Skip to content

fix(dashboard): hide empty analysis card from verify-permission holders - #996

Merged
lucca65 merged 1 commit into
masterfrom
fix/analysis-card-empty-verify-queue
Jul 7, 2026
Merged

lucca65 merged 1 commit into
masterfrom
fix/analysis-card-empty-verify-queue

Conversation

@lucca65

@lucca65 lucca65 commented Jul 7, 2026

Copy link
Copy Markdown
Member

Problem

Report (muda, 2026-07-07): a regular member ("Cissa") suddenly had "access to analyze actions", with an empty queue — she was never made an approver.

Root cause: #994 surfaced the dashboard analysis/timeline cards to any holder of the Verify permission so they could reach claims on role-based actions (empty validator list). But the default member role carries verify for the entire community:

0,MUDA member {invite,claim,order,verify,sell,transfer}

So all 6,966 muda members (and the equivalent in nearly every community) now saw an empty "actions for analysis" card. The only matching pending claims in muda are 2020–2021, filtered by backend #346's 2-year queue cutoff → empty queue.

Fix

  • Explicit validators unchanged — always see their analysis card.
  • Verify-only holders now see it only when they actually have votable claims waiting (analysis.count > 0). The dashboard already fetches available analysis unconditionally on init, so no extra query.

On-chain signing/voting path untouched; the contract stays the authority (a verify holder with a stray votable claim still reaches it, and can still vote via direct link regardless).

🤖 Generated with Claude Code

#994 surfaced the dashboard analysis/timeline cards to any holder of the
Verify permission so they could reach claims on role-based actions (empty
validator list). But the default `member` role carries Verify for the whole
community, so every member saw an empty "actions for analysis" card even
with nothing to vote on (reported on muda: a regular member suddenly had
"access to analyze actions", empty queue).

Explicit validators are unchanged — they always see their card. Verify-only
holders now see it just when they actually have votable claims waiting
(analysis.count > 0), which the dashboard already fetches unconditionally on
init. The on-chain signing/voting path is untouched; the contract stays the
authority.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@lucca65
lucca65 merged commit 2646ec0 into master Jul 7, 2026
5 checks passed
@lucca65
lucca65 deleted the fix/analysis-card-empty-verify-queue branch July 7, 2026 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant