Repository navigation
Use StructArmed on QA - #21
Open
samsonasik wants to merge 2 commits into
Open
samsonasik wants to merge 2 commits into
samsonasik wants to merge 2 commits into
Conversation
Author
|
@calebdw ready for review/merge 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR to make use of StructArmed.
This PR start apply StructArmed with initialize using
PSR4andCODEQUALITYpreset, and already help fix 19 violations.On
CODEQUALITYpreset, it help apply to use static on anonymous function when possible.Applied with single command:
Currently applied on
srcdirectory for easier to review.I also enable ruleset above so it show more ability of layering setup to define which layers each layer is allowed to depend on.
I also added to composer script so github action will auto use it with: