Repository navigation
Always record only one iteration per process - #343
Merged
Merged
Conversation
It already had outdated ABI mismatches, where it was missing `WasmBenchConfig` fields. Since no one is using or maintaining this, I'm taking the opportunity to remove it as we change the ABI in other ways that would otherwise expose native support's breakage in louder ways. We can always revive this if someone is sufficiently motivated in the future.
The leading size field lets the engine tell which trailing fields we actually allocated, so later fields can be added without breaking already-built engine libraries.
Member
Author
|
Okay bytecodealliance/wasmtime#14705 merged and I updated the wasmtime version we use in CI, so this should be good to go. |
fitzgen
added a commit
to bytecodealliance/are-we-fast-yet
that referenced
this pull request
Oct 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've found that samples were not independent with regard to their process in practice, which undermines our statistical analyses, and the overhead of process spawning is basically nothing compared to the cost of running an iteration, so this commit series makes us run each iteration in its own process.
The
--processesand--iterations-per-processCLI flags are replaced with a single-i/--itersflag.This also folds in The Last ABI Breakage We Will Ever Have (and therefore depends on bytecodealliance/wasmtime#14705 landing so we can point our CI builds of the bench API at an engine that uses the new ABI) so that we can cache compilation across processes when benchmarking just instantiation or execution.
Also removes the native benchmarking support, as it was already had a subtly mismatched ABI, and no one is actively using or maintaining it. If someone steps up in the future, we can always revive it pretty easily.
See each commit for details.
r? @cfallin