Add a note to explicitly state that signed pipeline are not supported … - #3155
Add a note to explicitly state that signed pipeline are not supported …#3155ss1909 wants to merge 1 commit into
Review submitted — approved
Review summary
Change reviewed
PR #3155 addresses Linear issue A-1677, which asks the documentation to state explicitly that signed pipelines are unsupported on Buildkite hosted agents. The change adds this information at both entry points identified by the issue:
pages/agent/buildkite_hosted.mdnow includes a Signed pipelines info callout. The callout links to the signed-pipelines documentation and states that signed pipeline validation is not supported for Buildkite hosted agents.pages/agent/self_hosted/security/signed_pipelines.mdnow states in its introduction that the feature can be enabled on self-hosted agents and is unavailable on Buildkite hosted agents.
The latest revision also converts the hosted-agent note from a bare blockquote to the repository's established 📘 callout format.
Evidence and verification
I read the Linear issue, PR description, complete diff, both changed files, and the existing review thread. The implementation now covers both documentation locations required by A-1677. I also checked nearby callouts in the agent documentation and confirmed that the new two-line callout follows the existing syntax.
The internal link /docs/agent/self-hosted/security/signed-pipelines maps to the existing file at pages/agent/self_hosted/security/signed_pipelines.md. The PR head remained at commit 48ebf3e0d3985edce2be7c076aeb46270335b4a8 through submission.
Checks run locally:
npx markdownlint-cli2@0.3 pages/agent/buildkite_hosted.md pages/agent/self_hosted/security/signed_pipelines.md— passed with zero errors.git diff --check origin/main HEAD— passed.- Internal link target existence check — passed.
Vale was not run because the vale executable is not installed in the review environment. The full RSpec suite and site build were not run for this documentation-only change. At the final status check, the Buildkite docs build #8817 was still pending; the other completed checks reported by the PR had passed.
Findings and verdict
The earlier blocking concern is resolved: the signed-pipelines page contains the required availability statement, the hosted-agent sentence uses correct subject-verb agreement, and the hosted-agent note now uses a valid info callout. I acknowledged the fix in the existing thread.
No new findings remained after the full diff and surrounding-content review. I submitted an APPROVE review with no new inline comments.
Trigger source: automatic.