Correct plan availability for Azure Entra ID SSO - #3153
Conversation
Azure Entra ID (Azure AD) is set up through the custom SAML path, which is an Enterprise plan feature, so Entra ID SSO is Enterprise-only. Add an Enterprise plan note to the Entra ID page and annotate the supported providers list on the SSO overview page with the plans each provider is available on. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01REYYduTXK8Qx2ktxzd7ABu
a0e6f9e to
15129b8
Compare
Microsoft renamed Azure Active Directory to Entra ID, so update the user-facing display text across the SSO docs: - pages/platform/sso.md: supported providers list entry - pages/platform/sso/azure_ad.md: 'edit or update your ... provider settings' callout - data/nav.yml: sidebar nav label (path unchanged) - data/llm_descriptions.yml: platform/sso provider list description Also removes the per-provider plan annotations added to the supported providers list earlier in this branch, as requested. URL slugs, file paths, heading anchors, Azure Portal UI labels (for example 'Provision Azure Active Directory Groups') and ADFS naming are deliberately unchanged. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VxSbqy6sef7hmYXzDmoHwo
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d8d5e4a0a3
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| * [Google Workspace](/docs/platform/sso/google-workspace) | ||
| * [Google Workspace (SAML)](/docs/platform/sso/google-workspace-saml) | ||
| * [Azure Active Directory](/docs/platform/sso/azure-ad) | ||
| * [Azure Entra ID](/docs/platform/sso/azure-ad) |
There was a problem hiding this comment.
The provider is named Microsoft Entra ID, not “Azure Entra ID,” as confirmed by the linked guide’s title and introduction (pages/platform/sso/azure_ad.md:1-6) and the existing Azure OIDC documentation (pages/pipelines/security/oidc/azure.md:24-28). This rename makes the provider list inconsistent with its destination page, while the same incorrect hybrid name is also introduced in the navigation and LLM description; use “Microsoft Entra ID” in all three labels.
AGENTS.md reference: AGENTS.md:L319-L320
Useful? React with 👍 / 👎.
![buildsworth-bk-app[bot]](https://avatars.githubusercontent.com/in/3010600?s=60&v=4){kind=small}
There was a problem hiding this comment.
The provider page now carries the Enterprise-plan note, but two documentation-correctness issues remain; details are inline.
Want to dig deeper?
Paste this into your agent to explore the findings from this review's Buildkite build:
Download the buildsworth logs from build 16063, then answer my questions about the findings.
Install the reading-buildsworth-logs skill to run this.
About buildsworth
Model: gpt-5.6-sol with xhigh thinking.
How to request a review: Comment @buildsworth-bk review on the PR, or request buildsworth-bk as a reviewer.
Risk labels (how buildsworth classifies risk) — buildsworth classifies risk itself from the diff. To let it approve, grant L2 approval by mentioning @buildsworth-bk (see L2 approval grant):
- L1 — Low risk (dep bumps, docs/copy, lockfiles, small presentational fixes). buildsworth may approve by default.
- L2 — Standard risk (new UI, additive API fields, refactors). Approved only with an L2 grant; otherwise comment-only.
- L3 — High risk (auth, migrations, payments, secrets, perf-critical paths). Human review always required.
| * [Google Workspace](/docs/platform/sso/google-workspace) | ||
| * [Google Workspace (SAML)](/docs/platform/sso/google-workspace-saml) | ||
| * [Azure Active Directory](/docs/platform/sso/azure-ad) | ||
| * [Azure Entra ID](/docs/platform/sso/azure-ad) |
There was a problem hiding this comment.
Blocking: The generic "Pro or Enterprise" note above this list still reads as if every provider here is available on both plans. A Pro customer can therefore still choose Azure from this overview without seeing that it requires Enterprise, while the PR description says this list will show per-provider availability. Please add the plan availability to the relevant provider entries here.
| - name: "OneLogin" | ||
| path: "platform/sso/onelogin" | ||
| - name: "Azure AD" | ||
| - name: "Azure Entra ID" |
There was a problem hiding this comment.
Blocking: The renamed product is Microsoft Entra ID, not "Azure Entra ID"; the guide's H1 and Microsoft link already use the official name. Please use "Microsoft Entra ID" consistently in this nav entry, the overview, the LLM description, and the warning in the guide.
|
Closing this — the change is moving to the private docs repo instead. The Enterprise-plan note for Microsoft Entra ID and the naming fixes will carry over there. Generated by Claude Code |
|
Closing: this was raised against the public mirror by mistake. The Azure Entra ID rename has moved to buildkite/docs-private#1964. One thing was not carried over and needs re-raising in > 📘 Enterprise plan feature
> Microsoft Entra ID (Azure AD) SSO is only available to Buildkite customers on the [Enterprise](https://buildkite.com/pricing) plan.The per-provider plan annotations this PR added to the supported providers list in The Generated by Claude Code |
Add the standard 'Enterprise plan feature' callout to the Azure Entra ID SSO page, matching the convention already used on the ADFS and custom SAML SSO pages. Wording is carried over from the closed buildkite#3153, with the provider name aligned to the 'Azure Entra ID' naming used elsewhere in this branch. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VxSbqy6sef7hmYXzDmoHwo
1 participant
Requested by Catalino Cuadrado, Chris Barrell · Slack thread
Before: the Azure AD SSO page draws no plan distinction, so any SSO-enabled customer reads the provider as available to them, and the provider is called "Azure Active Directory" / "Azure AD" across the SSO docs and nav.
After: the page carries an
Enterprise plan featurecallout — Microsoft Entra ID (Azure AD) SSO is only available on the Enterprise plan — and the provider is named "Azure Entra ID" in the SSO overview, the nav, and the LLM descriptions. The supported-providers list stays a plain list, with no per-provider plan labels.How: adds the Enterprise callout to
pages/platform/sso/azure_ad.md(matching the existing ADFS and Custom SAML notes), and renames the provider inpages/platform/sso.md,data/nav.ymlanddata/llm_descriptions.yml— the Azure AD → Entra ID naming update rides along in the same branch. The existing "SSO requires Pro or Enterprise" note in the overview is unchanged.Karen Sawrey (docs) should review the wording.
Generated by Claude Code