[Zach Dunn (zachdunn)]

The By page thumbnail pill repeated what the hover card already shows, and Settings opened a submenu with nothing on the row to say it could. Zach Dunn (@zachdunn) flagged both, plus a gap under the header that looked like the sidebar was sitting too low.

What it does

• Removes the overlay on By page thumbs (the "From GitHub" strip and the recent grid). The PR or issue stays on the hover card. The GitHub login from that pill (gh.author) moves onto the same card, and into the tile's accessible name, so it is not only on the image.
• By pull request and By repo never painted that pill. Their rows already show the PR label next to the strip, so those views are unchanged.
• Settings gets a chevron on the right. It points right on other pages and turns down while the submenu is open. The row sets aria-expanded. The chevron hides in the collapsed icon rail.

What it is not

• The sidebar is not pulled up under the header. That offset is the same 28px padding the main column uses (header is 61px, and both columns start at 89px). The workspace switcher then sits in the sidebar header's own 8px padding, which lines up with the Files tab labels. Leaving it keeps the two columns on the same grid.
• Settings is still a link, not a click-to-collapse control. Opening a settings page is what shows the submenu.

How to try it
Open a workspace's Files page on By page and hover a GitHub thumb. Open Settings and check the chevron, then leave Settings and check that it points right. On a phone, open the header menu on a settings page.

Technical notes

• contextLabel is gone from ShotThumb. The only callers were the By page recent grid and the From GitHub strip.
• The chevron is driven by an expands flag on the Settings nav item. Nested rows still come from the settings route.

Test plan

• pnpm --filter @uploads/web exec vitest run src/lib/shell-sidebar-data.test.ts src/lib/workspace-screenshots.test.ts
• Compared local By page before and after: the #12 · ZACHDUNN / #3351 · ZACHDUNN pills are gone on desktop and mobile, and the hover card still carries the PR.
• Settings submenu shows a downward chevron on desktop and in the mobile drawer; on Files the chevron points right and the submenu is closed.
• Measured the header (bottom 61) against the nav and content columns (both top 89). No layout change.
• CI lint and test

By page, desktop:

By page, mobile:

Settings:

  

[changeset-bot]

⚠️ No Changeset found

Latest commit: a97951b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[coderabbitai]

Important

Review skipped

Auto reviews are limited based on label configuration.

🏷️ Required labels (at least one): 2

• coderabbit:review
• review

🚫 Excluded labels (none allowed): 1

• wip

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

Run configuration

• Source mode: Auto
• Repository: Unavailable
• Branch: Unavailable
• File: No configuration file from this repository applied
• Commit: Unavailable
• Layers: Organization UI
• Review profile: CHILL
• Plan: Advanced
• Run ID: 0071dcb3-ee28-4d5b-a8b8-3282f19468a3

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[uploads-sh]

/account/workspaces/:name/files

Settings chevron points right while the submenu is closed · after

By page thumbs without the overlay pill · after

Settings row on Files, before the chevron · before

By page thumbs with the PR and author pill · before

By page thumbs without the overlay pill · after

By page thumbs with the PR and author pill · before

/account/workspaces/:name/settings

Settings chevron points down while the submenu is open · after

Settings chevron points down while the submenu is open · after

Other

9 more attachments

• before-settings-desktop.png · Settings submenu open, no chevron on the row · /account/workspaces/:name/settings · before
• by-page-after-on-a-phone-pills-removed.png
• by-page-after-thumbs-without-the-overlay-pills.png
• by-page-before-on-a-phone-pills-still-on-the-thumbs.png
• by-page-before-with-pr-pills-on-the-from-github-thumbs.png
• files-after-chevron-pointing-right-while-settings-is-closed.png
• mobile-settings-drawer-after-chevron-pointing-down.png
• settings-after-chevron-pointing-down-beside-the-open-submenu.png
• settings-before-submenu-open-with-no-chevron.png

AI notes · 2 warnings

• ⚠️ An after screen may not show the change
  • after-pages-mobile.png looks like it is still loading
• ⚠️ Before and after look the same
  • before-files-desktop.png and after-files-desktop.png look the same
  • before-settings-desktop.png and after-settings-desktop.png look the same

_{uploads put <file> --pr 1316 · docs}