Different init - #187
Open
Koala Yeung (yookoala) wants to merge 2 commits into
Open
Conversation
Fix for problem pulling photos from Flickr
The original supersized library generate 2 divs automatically:
1. #supersized-loader
2. #supersized
These 2 divs are generated even if the library is not called by
explicit `$('selector').supersized()` call. That is an unexpected
behaviour.
This commit movied the append statement into the supersized
plugin. The divs are now appended only if:
1. $.supersized is called explicitly; and
2. The #supersized div is previously not existed
The behaviour is a slightly different from before, but all other
behaviour reserved.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The original supersized library generate 2 divs automatically:
#supersized-loader#supersizedThese 2 divs are generated even if the library is not called by
explicit
$('selector').supersized()call. That is an unexpectedbehaviour.
This commit movied the append statement into the supersized
plugin. The divs are now appended only if:
$.supersizedis called explicitly; and#supersizeddiv is previously not existedThe behaviour is a slightly different from before, but all other
behaviour reserved.