Conversation
Author
|
Closing this draft in favor of a spec-first, reviewable PR series. No maintainer action is required here. The implementation history is preserved, and follow-up work will be separated into: (1) the BSV upto specification, (2) any independently justified behavior-preserving BSV refactor, and (3) the complete TypeScript implementation with integration coverage. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Extends the BSV mechanism from x402-foundation#2890 with the existing
uptoscheme semantics: authorize a maximum first, then settle one fully signed transaction at the actual amount.SIGHASH_SINGLE | FORKID(0x43) cap signatures while recipient control inputs sign each complete version withALL | FORKID(0x41).uptopayments and cumulative stream versions through the same payload and role entrypoints; stream remains application behavior, not a new protocol object.validAfter,nLockTime, anddeadline; requires complete BEEF plus an application-supplied PoW/SPV verifier.The Exact production path is unchanged. This PR targets
feat/bsv-exact-schemeand depends on x402-foundation#2890.AI disclosure: Significant implementation assistance came from OpenAI Codex. This remains a Draft pending human review; the signing and settlement paths were exercised by focused adversarial tests and independent security/API review passes.
Tests
pnpm testfromtypescript: 57/57 tasks passed.pnpm testin@x402/bsv: 165/165 tests passed.pnpm lint:checkin@x402/bsv.pnpm buildin@x402/bsv(ESM, CJS, and declarations).git diff --check.Standalone
tsc --noEmithas only the three test typing errors already present on the x402-foundation#2890 base; nouptotyping errors remain.Checklist