Repository navigation
chore: sync CLI languages with Rust CLI changes - #1297
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated sync of language CLIs from Rust CLI changes.
Source commit:
573dbc5Workflow run: View logs
Language status:
Sync findings
C#
Divergences
receivecommand (bolt11 method): Rust CLI added--preimageflag to supply a caller-chosen preimage for the bolt11 invoice, withconflicts_with = "hodl". C# CLI was missing this flag and always passedpreimage: null.Applied
--preimageflag parsing inCommands.csHandleReceivemethod--hodland--preimageare specifiedpreimagevalue through to theBolt11Invoiceconstructor instead of hardcodednullpreimagetohodlPreimageinside thehodlblock to avoid shadowing the flag valueSkipped
Dart
Divergences
receivecommand: Rust CLI added--preimageoption for bolt11 invoices (conflicts with--hodl), Dart CLI was hardcodingpreimage: nullApplied
--preimageoption to thereceivecommand's ArgParser incommands.dart--hodland--preimageflags incommands.dartReceivePaymentMethod.bolt11Invoice()instead ofnullincommands.dartSkipped
Go
Divergences
receivecommand bolt11 method: Rust CLI has--preimageflag (conflicts with--hodl) that passes a caller-supplied preimage toReceivePaymentMethodBolt11Invoice.preimage; Go CLI was missing it.Applied
--preimageflag tohandleReceiveincommands.go, with mutual-exclusion check against--hodl, passing the value aspm.Preimageon theReceivePaymentMethodBolt11Invoicestruct.Skipped
Kotlin
Divergences
receivecommand'sbolt11method: Rust CLI added--preimageflag to supply a caller-provided preimage (hex) for the bolt11 invoice, conflicting with--hodl. Kotlin CLI hadpreimage = nullhardcoded.Applied
--preimage <hex>flag parsing tohandleReceiveinCommands.kt--preimageto the help text inhandleReceiveinCommands.kt--hodland--preimageinCommands.ktpreimagevalue through toReceivePaymentMethod.Bolt11Invoiceconstructor inCommands.ktSkipped
Python
Divergences
receive --preimageflag missing from Python CLI: Rust CLI added--preimageoption for bolt11 invoices (conflicts with--hodl), Python CLI was always passingpreimage=NoneApplied
--preimageargument to_build_receive_parser()incommands.py--hodland--preimagein_handle_receive()incommands.pypreimage=Nonetopreimage=args.preimagein theBOLT11_INVOICEconstructor incommands.pySkipped
React Native
Divergences
receivecommand's bolt11 path: Rust CLI added--preimageflag (hex string, conflicts with--hodl) that is passed toBolt11Invoice'spreimagefield; React Native CLI hadpreimage: undefinedhardcodedApplied
--preimage <hex>flag parsing, conflict check with--hodl, and pass-through toBolt11Invoiceconstructor incommands.ts--preimageto the usage help text for thereceivecommandSkipped
Swift
Divergences
receive --preimage <hex>flag missing from Swift CLI: Rust CLI added--preimageoption to theReceivecommand for bolt11 invoices, allowing a caller-supplied preimage instead of one the SDK generates. The flag conflicts with--hodl. Swift CLI hadpreimage: nilhardcoded.Applied
--preimageflag parsing inhandleReceiveinCommands.swift--hodland--preimageflags.bolt11Invoice(... preimage:)instead ofnilSkipped
TypeScript
Divergences
receive-paymentbolt11 method missing--preimageCLI option that Rust CLI added (conflicts with--hodl)receive-paymentbolt11 method hardcodedpreimage: undefinedinstead of passing through CLI-provided valueApplied
--preimage <hex>option toreceive-paymentcommand incommands.js--hodl/--preimagemutual exclusion check in the bolt11 case incommands.jspreimage: undefinedtopreimage: options.preimagein bolt11 payment method construction incommands.jsSkipped
All languages synced cleanly. This PR merges automatically once the gating CI checks pass (integration test checks and failures already on the base commit excluded). New failures get automated fix commits first.