Repository navigation
Conversation
ycarogabriel-lgtm
added a commit
to ycarogabriel-lgtm/AnyPS5
that referenced
this pull request
Oct 19, 2026
…capture directories (@jotitadev) This branch gathers the open macOS work, and this PR is part of it: it is merged here with its author credited, so the integration carries it now and merging it first in main only shrinks this branch. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
12 tasks done
|
Some comparisons could not be completed because a pull request conflicts with the base branch. Review these shared files manually before concluding that there is no overlap.
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Follow-up to #6259. On macOS, Finder writes a
.DS_Storefile into any folder it shows, so opening the compute capture directory in Finder made the next new capture fail withcapture directory contains an unexpected entry. WithWriteOptionalthat error is not swallowed, so it reaches the caller like any other invalid directory. The author of #6259 confirmed it and asked for a separate PR (#6259 (comment)).The scan shared by
WriteandWriteOptionalnow skips an entry only when it is a regular file named exactly.DS_Store. Skipped entries do not count toward the 128-entry or 256 MiB bounds. Everything else is unchanged: other files (including other dot-files), a symbolic link named.DS_Storeand a directory named.DS_Storeare still rejected, so--optional-invalidkeeps failing on a foreign entry as before.The
--optional-invalidcase now writes a.DS_Storeinto a fresh capture directory, checks thatWriteandWriteOptionalboth add a record and leave the file alone, then adds the existingforeignfile and checks thatWrite(with its diagnostic) andWriteOptionalstill reject the directory.Tested
macOS 27.2 on an Apple M2 Max, Xcode 27.0 (Apple clang 21.0.0, libc++). Base:
mainfd423f9 (this head a51bb03 merges cleanly onto it). libSceAgcDriver does not build on macOS yet, so I builttests/ComputePipelineCapture.cppstandalone withExecution/src/ComputePipelineCapture.cpp(-std=c++20 -O2, Vulkan SDK 1.4.363 headers), for-arch arm64and-arch x86_64(run under Rosetta). Every mode: default,--optional-entry-cap,--optional-byte-cap,--optional-io,--optional-invalid.main:--optional-invalidfails withcapture directory contains an unexpected entryon both architectures; the other four modes pass.main, scan from this branch: 5/5 pass on both architectures (theforeignentry is still rejected).Not run: the CTest targets on Linux or Windows (full build).
Checklist
main; no other open PR implements the same functionsNotImplemented_nid_no_patch); silent stubs are listed under Silent stubs in their library's technical debt file.mdfiles or images added to the repository (attach them to this PR)🤖 Generated with Claude Code