Repository navigation
fix(agc): bound the sampled depth-plane copies - #7705
Open
AnthonyClemens wants to merge 2 commits into
Open
AnthonyClemens wants to merge 2 commits into
AnthonyClemens wants to merge 2 commits into
Conversation
|
Some comparisons could not be completed because a pull request conflicts with the base branch. Review these shared files manually before concluding that there is no overlap.
|
12 tasks done
jotitadev
reviewed
Oct 19, 2026
jotitadev
left a comment
jotitadev
left a comment
Contributor
There was a problem hiding this comment.
Apple GPU / MoltenVK run. agc_driver_depth_plane_sampling_evicting and the depth-plane tests pass on Metal. Two of the tests listed as unchanged, depth_plane_guest_layers and depth_storage, are skipped on macOS on main. With a loader patch they run and pass with this PR.
Machine: Apple M2 Max, macOS 27.2, x86-64 build under Rosetta. Head 0258a05, PR diff applied cleanly. Drivers: MoltenVK 1.4.2 (Vulkan SDK 1.4.363.0) and MoltenVK main + SPIRV-Cross #2704.
Tested: the tree is main a373e85 + mugurc's macOS series (ci/macos-series-2) + the PRs needed to build on macOS (#6667, #6668, #7524, #6969, and two files of #7332), not plain main (it doesn't build on macOS yet). Also in the same build: #7707, #7698, #7687, #7691 and #7705 (they touch different files and applied cleanly together), plus a test-only patch that lets nine AGC fixtures load the Vulkan loader on macOS (branch jotitadev:fix/agc-tests-vulkan-loader-macos). Base on that tree: 40 ^agc failures with MoltenVK 1.4.2 and 26 with MoltenVK main + #2704.
agc_driver_depth_plane_sampling_evicting(APS5_DEPTH_PLANE_COPY_MIB=1),depth_plane_sampling,depth_plane_fill,depth_plane_guest_layers,depth_storage,depth_compare_copy,depth_surface_from_storageanddepth_bits_guest_memory: all pass 3 of 3 on both drivers.depth_storage_dispatchanddepth_storage_reusealso pass in the full-suite runs.DepthPlaneGuestLayers.cppandDepthStorage.cpploadlibvulkan.so.1themselves, without portability enumeration. Without the loader patch they printskipped, no usable Vulkan deviceon macOS, so they don't cover this change there.- Full
^agcsuite with the stack: 42 of 730 fail on MoltenVK 1.4.2 and 28 of 730 on MoltenVK main + #2704. That is the base failures plusagc_driver_pooled_buffer_rangeandagc_performance_overlay, which only run because of the loader patch and fail for unrelated reasons. No new failure from this PR.
I didn't do a without-the-fix control. Without the fix, the evicting test's variable does nothing, so the test would pass anyway.
GPUs tested: Apple M2 Max (MoltenVK 1.4.2; MoltenVK main + SPIRV-Cross #2704)
Written with AI assistance (Claude Code). I ran the builds and tests above on my machine.
|
NVIDIA data: GeForce RTX 4090, driver 617.42, Windows 11 Pro 26200, WinLibs GCC 15.2.0 r7, Release,
AI-assisted: yes (Claude Code) |
Contributor
|
Windows regression check on an Intel UHD 770 and an AMD RX 9070 XT: no new failures in the full CTest results. Windows 11 Pro 26300, WinLibs GCC 15.2.0 r7, Release, every execution test built. Intel UHD Graphics 770 ( This PR adds no test, so I ran full CTest (
AI-assisted: yes (Claude Code) |
A depth plane copy (a depth surface sampled as several slices, an integer view or a cube) was kept until the device went away, with a staging buffer of its own size, and a staging buffer it outgrew was never freed. Every depth surface a scene ever sampled this way held its copy, so device memory grew with each new scene (0.4-1.2 GB in RE2 after a level load). The copies now share their image's ownership with the views they hand out, the recorder keeps the image and the staging buffer until the recorded copy has run, and past APS5_DEPTH_PLANE_COPY_MIB (default 256; 0 keeps every copy) the least recently used copies leave the cache. A copy made again refills from the surface and guest memory as a new one does. agc_driver_depth_plane_sampling_evicting runs the plane sampling cases with a 1 MiB budget. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…est copy agc_driver_depth_plane_sampling_evicting passes --evicting, and the test then requires a single depth plane copy left in the cache (DepthPlaneCopyCount) after the cases. With APS5_DEPTH_PLANE_COPY_MIB=0, which keeps every copy, it fails with "8 depth plane copies were kept with a 1 MiB budget, expected only the newest". The explanatory comments move to the pull request. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
AnthonyClemens
force-pushed
the
fix/agc-bound-depth-plane-copies
branch
from
October 19, 2026 14:06
0258a05 to
f440e3b
Compare
github-actions
Bot
added
the
unblocks title
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
A depth plane copy (a depth surface sampled as several slices, an integer view or a cube) stayed in
planeCopies()until the device went away. Each copy also kept a staging buffer the size of the copy. A staging buffer it outgrew was moved intoretiredStagingand never freed. So every depth surface a scene ever sampled this way kept its copy, and device memory grew with each new scene.With this change:
OwnedImageowner of the depth-planeTextureconstructor. A copy can leave the cache while a draw or a cached resource set still samples it.APS5_DEPTH_PLANE_COPY_MIB(default 256;0keeps every copy), the least recently used ones leave the cache. A copy made again refills from the depth surface and guest memory, as a new copy does.DepthPlaneCopyCount()returns the number of cached copies, for the test.In Resident Evil 2 (PPSA04288), these were the peak
depth plane copyallocations underAPS5_VK_MEMORY_TRACK:depth plane copyThe scene rendered the same either way. Without the bound, the staging buffers of the same size added roughly as much again under
device buffer.Tested
Windows 11 Pro (10.0.26200), AMD Radeon RX 9070 XT, WinLibs GCC 15.2.0, Release, on
main85029a0.agc_driver_depth_plane_sampling_evicting. It runs the depth-plane sampling cases withAPS5_DEPTH_PLANE_COPY_MIB=1and--evicting. Every copy but the newest leaves the cache, so later cases rebuild evicted copies and must read the same values. It then requires one copy left in the cache.APS5_DEPTH_PLANE_COPY_MIB=0, which keeps every copy asmaindoes, fails:8 depth plane copies were kept with a 1 MiB budget, expected only the newest.depth_plane_sampling,depth_plane_guest_layers,depth_plane_fill,depth_compare_copy,depth_storage,depth_storage_dispatch,depth_storage_reuse,depth_surface_from_storage,depth_bits_guest_memory.main. As MaxLikesCode noted, theprepared_shaders_abi_deferred_*failures came from the old base.Thanks to MaxLikesCode, savvaniss and jotitadev for the NVIDIA, Intel/AMD and MoltenVK runs.
Checklist
main; no other open PR implements the same functionsNotImplemented_nid_no_patch); silent stubs are listed under Silent stubs in their library's technical debt file.mdfiles or images added to the repository (attach them to this PR)