Repository navigation
Conversation
|
Some comparisons could not be completed because a pull request conflicts with the base branch. Review these shared files manually before concluding that there is no overlap.
|
|
Independent hardware run, head |
|
#7207 has merged, and this PR builds on the same code. Could you rebase onto current main? We will run full CI on the new head from there. |
…ending A packed color target (10_11_11 unorm or 11_11_10 float) renders through an R32_UINT attachment, which cannot blend, so any enabled blend was refused. A blend whose color equation is ONE * source + ZERO * destination writes the source unchanged, and the target has no alpha to blend, so it is now drawn with blending disabled. PPSA01317 enables such a blend (CB_BLEND_CONTROL 0x60010001) on a packed target during boot. Other blends are still refused. AI-assisted: yes
b7fa913 to
da158d6
Compare
|
Rebased onto main 5de7a46 after #7207. The replace rule (ONE * src + ZERO * dst drawn with blending disabled) now covers 11_11_10 float targets too: AI-assisted: yes |
Integrate the remaining regression coverage from Gjonn PRs boykopovar#7238, boykopovar#7243 and boykopovar#7256 while retaining the larger storage heap, packed float blending and shared depth arrays. The offset folding from boykopovar#7240 is already covered. Co-authored-by: Gjon Gojcevic <gjonn@hotmail.com>
Integrate the remaining regression coverage from Gjonn PRs boykopovar#7238, boykopovar#7243 and boykopovar#7256 while retaining the larger storage heap, packed float blending and shared depth arrays. The offset folding from boykopovar#7240 is already covered. Co-authored-by: Gjon Gojcevic <gjonn@hotmail.com>
|
RTX 4090 data point on PPSA01317, the title this PR lists under Unblocks. Short version: with the PR, the Setup. Gran Turismo 7 PPSA01317 01.000.001 (base package), Windows 11 (26200), RTX 4090 (NVIDIA 616.92), AMD Ryzen 7 5800X, MinGW-w64 GCC 15.2.0 r7 (UCRT), Release
Both sets carry the Result on B (the A/B that tests this PR). Without #7243, 3 of 3 runs abort on That is the
Result on A, for the record. On current stderr of run B-3 (warm, box idle) from the second 10 s summary to the abort, per-shader
|
Integrate the remaining regression coverage from Gjonn PRs boykopovar#7238, boykopovar#7243 and boykopovar#7256 while retaining the larger storage heap, packed float blending and shared depth arrays. The offset folding from boykopovar#7240 is already covered. Co-authored-by: Gjon Gojcevic <gjonn@hotmail.com>
Integrate the remaining regression coverage from Gjonn PRs boykopovar#7238, boykopovar#7243 and boykopovar#7256 while retaining the larger storage heap, packed float blending and shared depth arrays. The offset folding from boykopovar#7240 is already covered. Co-authored-by: Gjon Gojcevic <gjonn@hotmail.com>
Integrate the remaining regression coverage from Gjonn PRs boykopovar#7238, boykopovar#7243 and boykopovar#7256 while retaining the larger storage heap, packed float blending and shared depth arrays. The offset folding from boykopovar#7240 is already covered. Co-authored-by: Gjon Gojcevic <gjonn@hotmail.com>
Integrate the remaining regression coverage from Gjonn PRs boykopovar#7238, boykopovar#7243 and boykopovar#7256 while retaining the larger storage heap, packed float blending and shared depth arrays. The offset folding from boykopovar#7240 is already covered. Co-authored-by: Gjon Gojcevic <gjonn@hotmail.com>
Integrate the remaining regression coverage from Gjonn PRs boykopovar#7238, boykopovar#7243 and boykopovar#7256 while retaining the larger storage heap, packed float blending and shared depth arrays. The offset folding from boykopovar#7240 is already covered. Co-authored-by: Gjon Gojcevic <gjonn@hotmail.com>
Integrate the remaining regression coverage from Gjonn PRs boykopovar#7238, boykopovar#7243 and boykopovar#7256 while retaining the larger storage heap, packed float blending and shared depth arrays. The offset folding from boykopovar#7240 is already covered. Co-authored-by: Gjon Gojcevic <gjonn@hotmail.com>
Integrate the remaining regression coverage from Gjonn PRs boykopovar#7238, boykopovar#7243 and boykopovar#7256 while retaining the larger storage heap, packed float blending and shared depth arrays. The offset folding from boykopovar#7240 is already covered. Co-authored-by: Gjon Gojcevic <gjonn@hotmail.com>
|
RTX 4090 data point on PPSA01317 for the blend this PR leaves refused. After today's chain on D4697 (this PR + #7254 / #7256 + #5958 + #6815 + #7550 on That is Setup. Gran Turismo 7 PPSA01317 01.000.001 (base package), Windows 11 (26200), RTX 4090 (NVIDIA 616.92), AMD Ryzen 7 5800X, MinGW-w64 GCC 15.2.0 r7 (UCRT), Release Runs. The print fires once per run, immediately before the refusal, and no other blend into a packed target is reported before it (the
Screen: the "Sony Interactive Entertainment presents" splash, then a black window, title-bar counter about 1,325 frames and 12 FPS at the abort. Nothing gets further; the equation above is the only thing between this tree and whatever comes next on this box. One note on timing, since it affects anyone measuring this title: the same tree took 188 s and more than 300 s to reach this draw in earlier runs today. That was host pipeline compilation, not the title: the stderr of run 3 (warm, box idle) from the save-data mount to the abort, the per-shader
|
Integrate the remaining regression coverage from Gjonn PRs boykopovar#7238, boykopovar#7243 and boykopovar#7256 while retaining the larger storage heap, packed float blending and shared depth arrays. The offset folding from boykopovar#7240 is already covered. Co-authored-by: Gjon Gojcevic <gjonn@hotmail.com>
Integrate the remaining regression coverage from Gjonn PRs boykopovar#7238, boykopovar#7243 and boykopovar#7256 while retaining the larger storage heap, packed float blending and shared depth arrays. The offset folding from boykopovar#7240 is already covered. Co-authored-by: Gjon Gojcevic <gjonn@hotmail.com>
Integrate the remaining regression coverage from Gjonn PRs boykopovar#7238, boykopovar#7243 and boykopovar#7256 while retaining the larger storage heap, packed float blending and shared depth arrays. The offset folding from boykopovar#7240 is already covered. Co-authored-by: Gjon Gojcevic <gjonn@hotmail.com>
Integrate the remaining regression coverage from Gjonn PRs boykopovar#7238, boykopovar#7243 and boykopovar#7256 while retaining the larger storage heap, packed float blending and shared depth arrays. The offset folding from boykopovar#7240 is already covered. Co-authored-by: Gjon Gojcevic <gjonn@hotmail.com>
Integrate the remaining regression coverage from Gjonn PRs boykopovar#7238, boykopovar#7243 and boykopovar#7256 while retaining the larger storage heap, packed float blending and shared depth arrays. The offset folding from boykopovar#7240 is already covered. Co-authored-by: Gjon Gojcevic <gjonn@hotmail.com>
Integrate the remaining regression coverage from Gjonn PRs boykopovar#7238, boykopovar#7243 and boykopovar#7256 while retaining the larger storage heap, packed float blending and shared depth arrays. The offset folding from boykopovar#7240 is already covered. Co-authored-by: Gjon Gojcevic <gjonn@hotmail.com>
Integrate the remaining regression coverage from Gjonn PRs boykopovar#7238, boykopovar#7243 and boykopovar#7256 while retaining the larger storage heap, packed float blending and shared depth arrays. The offset folding from boykopovar#7240 is already covered. Co-authored-by: Gjon Gojcevic <gjonn@hotmail.com>
Integrate the remaining regression coverage from Gjonn PRs boykopovar#7238, boykopovar#7243 and boykopovar#7256 while retaining the larger storage heap, packed float blending and shared depth arrays. The offset folding from boykopovar#7240 is already covered. Co-authored-by: Gjon Gojcevic <gjonn@hotmail.com>
Integrate the remaining regression coverage from Gjonn PRs boykopovar#7238, boykopovar#7243 and boykopovar#7256 while retaining the larger storage heap, packed float blending and shared depth arrays. The offset folding from boykopovar#7240 is already covered. Co-authored-by: Gjon Gojcevic <gjonn@hotmail.com>
Integrate the remaining regression coverage from Gjonn PRs boykopovar#7238, boykopovar#7243 and boykopovar#7256 while retaining the larger storage heap, packed float blending and shared depth arrays. The offset folding from boykopovar#7240 is already covered. Co-authored-by: Gjon Gojcevic <gjonn@hotmail.com>
Integrate the remaining regression coverage from Gjonn PRs boykopovar#7238, boykopovar#7243 and boykopovar#7256 while retaining the larger storage heap, packed float blending and shared depth arrays. The offset folding from boykopovar#7240 is already covered. Co-authored-by: Gjon Gojcevic <gjonn@hotmail.com>
Integrate the remaining regression coverage from Gjonn PRs boykopovar#7238, boykopovar#7243 and boykopovar#7256 while retaining the larger storage heap, packed float blending and shared depth arrays. The offset folding from boykopovar#7240 is already covered. Co-authored-by: Gjon Gojcevic <gjonn@hotmail.com>
Integrate the remaining regression coverage from Gjonn PRs boykopovar#7238, boykopovar#7243 and boykopovar#7256 while retaining the larger storage heap, packed float blending and shared depth arrays. The offset folding from boykopovar#7240 is already covered. Co-authored-by: Gjon Gojcevic <gjonn@hotmail.com>
Integrate the remaining regression coverage from Gjonn PRs boykopovar#7238, boykopovar#7243 and boykopovar#7256 while retaining the larger storage heap, packed float blending and shared depth arrays. The offset folding from boykopovar#7240 is already covered. Co-authored-by: Gjon Gojcevic <gjonn@hotmail.com>
Integrate the remaining regression coverage from Gjonn PRs boykopovar#7238, boykopovar#7243 and boykopovar#7256 while retaining the larger storage heap, packed float blending and shared depth arrays. The offset folding from boykopovar#7240 is already covered. Co-authored-by: Gjon Gojcevic <gjonn@hotmail.com>
What
A packed color target (
ColorExportPackingother thanNone: the 10_11_11 unorm target and, since #7207, the 11_11_10 float target) renders through anR32_UINTattachment, which cannot blend, soDecodeStaterefused any enabled blend withblending into a 10_11_11 unorm color target is unsupported(or... an 11_11_10 float color target ...).A blend whose color equation is
ONE * source + ZERO * destination(CB_BLEND_CONTROLwithCOLOR_SRCBLEND = ONE,COLOR_DESTBLEND = ZERO,COLOR_COMB_FCN = ADD) writes the source color unchanged, and a packed target has no alpha channel for the alpha equation to affect, so such a draw is now decoded with blending disabled. Every other blend into a packed target is still refused.On PPSA01317 a draw enables
CB_BLEND_CONTROL 0x60010001on a packed target during boot and the title aborts with the refusal above; with this change it gets past it onmain.unorm10_11_11TargetTests(agc_driver_graphics) now decodes two replace blends (0x40010001, and0x60050001whose alpha equation differs) into a 10_11_11 unorm target and requires blending to be disabled with the packing kept, and still requires an additive blend (0x40010101) and aSRC_ALPHAblend (0x40010005) to be refused.float11_11_10TargetTestslikewise decodes three replace blends (0x40010001,0x60010001as PPSA01317 sets it, and0x60050001) into an 11_11_10 float target and requires blending to be disabled with the packing and the reversed component mapping kept, and still requires0x60010101and0x40010005to be refused. Onmainthe test fails withblending into a 10_11_11 unorm color target is unsupported; it passes with the change.The check sits on the shared packed-target path, so one line covers both packings. Rebased onto
mainafter #7207 merged.Tested
Windows 11, MinGW GCC Release build with
BUILD_TESTING=ON.agc_driver_graphicsfails onmain(with only the test applied) and passes with the change.agc_shader_memory_tests,agc_shader_device_profile_tests,agc_driver_graphics_tests,agc_driver_packed_float_color_target_testsandagc_driver_packed_unorm_color_target_tests(26 tests) passes.python tools/check_conventions.py --base origin/mainpasses;tools/check_test_registration.pyreports no unregistered tests.Checklist
main; no other open PR implements the same functionsNotImplemented_nid_no_patch); silent stubs are listed under Silent stubs in their library's technical debt file.mdfiles or images added to the repository (attach them to this PR)