Repository navigation
fix(libkernel): return EFAULT from truncate, utimes, mkdir, rmdir, and rename for a null path - #7114
Conversation
|
Thanks @pushkarreddyy, this looks right too: |
|
Thanks @oneandonlydean! Acknowledged — I have this folded together with #7110 and #7113 on a clean branch rebased on latest main, and will close this once #7108 merges. |
|
Other open pull requests touch the same code. Merging one will break the other, or both implement the same thing. If this one builds on them, list them in Depends on.
Some comparisons could not be completed because a pull request conflicts with the base branch. Review these shared files manually before concluding that there is no overlap.
|
…d rename for a null path
53d1069 to
7bb7608
Compare
What
Following @oneandonlydean's review directive in #7114:
Folds #7110 (
sceKernelTruncate,sceKernelUtimes), #7113 (sceKernelMkdir,sceKernelRmdir), and #7114 (sceKernelRename) together into this single PR, building cleanly on top of companion PR #7108 (sceKernelStat,sceKernelUnlink).Like FreeBSD 11 (
kern/vfs_syscalls.c), null path pointers reject early withEFAULT(0x8002000e) instead of throwing unhandled exceptions at runtime.Closes #7110.
Closes #7113.
Tested
python tools/check_conventions.py --base origin/mainpasses with 0 findings.core/libs/tests/GuestPosixScalarIo.cppunit tests cover null path rejection for all 5 functions returning0x8002000e.Checklist
main; no other open PR implements the same functionsNotImplemented_nid_no_patch); silent stubs are listed under Silent stubs in their library's technical debt file.mdfiles or images added to the repository (attach them to this PR)