Skip to content

fix(tests): load AGC libraries for the pipeline-clear regression on Windows - #6827

Closed
simonbronk wants to merge 2 commits into
boykopovar:mainfrom
simonbronk:codex/pipeline-clear-windows-test
Closed

simonbronk wants to merge 2 commits into
boykopovar:mainfrom
simonbronk:codex/pipeline-clear-windows-test

Conversation

@simonbronk

Copy link
Copy Markdown
Contributor

What

Follow-up to #6814; please merge it first. Its original commit 81e3db853c00453a04668e2c62e8b969f24d324b is preserved unchanged with its original authorship. Only the final commit is this Windows test-registration correction; until #6814 merges, the diff also contains that PR.

The new agc_pipeline_library_clear_waits_for_build test does not receive the Windows DLL search path that its neighbouring agc_pipeline_journal test uses. On Windows its CTest invocation timed out after 30.02 seconds; launching with the same missing DLL directory exits with 0xC0000135. The identical executable succeeds with the directory available.

Add the new test to the existing WIN32 PATH property. No runtime or timeout change.

Tested

Windows x64, supported WinLibs MinGW-w64 GCC 15.2.0 r7 UCRT, CMake 4.4.4, Release, BUILD_TESTING=ON, SPIRV-Tools disabled. Current main 82ddae75b6761757f3d3ba9c0723647469270f76, parent #6814 81e3db853c00453a04668e2c62e8b969f24d324b.

Checklist

@github-actions

github-actions Bot commented Oct 16, 2026 •

Copy link
Copy Markdown

Other open pull requests touch the same code. Merging one will break the other, or both implement the same thing. If this one builds on them, list them in Depends on.

Pull request Conflicting files (lines on main) Same exports Same new files
PR 6320 core/libs/prx/libSceAgcDriver/tests/Graphics.cpp L7811
PR 6641 core/libs/prx/libSceAgcDriver/Graphics/src/PipelineLibrary.cpp L55-56
PR 6973 core/libs/prx/libSceAgcDriver/tests/Graphics.cpp L5256, L7928

Some comparisons could not be completed because a pull request conflicts with the base branch. Review these shared files manually before concluding that there is no overlap.

Pull request Shared files not compared
PR 1341 core/libs/prx/libSceAgcDriver/CMakeLists.txt
PR 1368 core/libs/prx/libSceAgcDriver/CMakeLists.txt
PR 1395 core/libs/prx/libSceAgcDriver/CMakeLists.txt
core/libs/prx/libSceAgcDriver/Execution/src/VulkanDevice.cpp
core/libs/prx/libSceAgcDriver/tests/Graphics.cpp
PR 1896 core/libs/prx/libSceAgcDriver/CMakeLists.txt
core/libs/prx/libSceAgcDriver/Execution/include/Driver/Shaders/ShaderRegistry.hpp
core/libs/prx/libSceAgcDriver/Execution/src/Driver/Shaders/ShaderRegistry.cpp
PR 4040 core/libs/prx/libSceAgcDriver/Execution/src/VulkanDevice.cpp
core/libs/prx/libSceAgcDriver/tests/Graphics.cpp
PR 4048 core/libs/prx/libSceAgcDriver/CMakeLists.txt
core/libs/prx/libSceAgcDriver/Execution/src/VulkanDevice.cpp
PR 4072 core/libs/prx/libSceAgcDriver/Execution/src/VulkanDevice.cpp
PR 4339 core/libs/prx/libSceAgcDriver/CMakeLists.txt
PR 4472 core/libs/prx/libSceAgcDriver/Execution/src/VulkanDevice.cpp
PR 4650 core/libs/prx/libSceAgcDriver/CMakeLists.txt
core/libs/prx/libSceAgcDriver/Execution/src/VulkanDevice.cpp
core/libs/prx/libSceAgcDriver/tests/Graphics.cpp
PR 4891 core/libs/prx/libSceAgcDriver/CMakeLists.txt
core/libs/prx/libSceAgcDriver/Execution/src/VulkanDevice.cpp
PR 5021 core/libs/prx/libSceAgcDriver/CMakeLists.txt
core/libs/prx/libSceAgcDriver/Execution/src/VulkanDevice.cpp
PR 5115 core/libs/prx/libSceAgcDriver/Execution/include/Driver/Shaders/ShaderRegistry.hpp
core/libs/prx/libSceAgcDriver/Execution/src/Driver/Shaders/ShaderRegistry.cpp
PR 5371 core/libs/prx/libSceAgcDriver/CMakeLists.txt
PR 5390 core/libs/prx/libSceAgcDriver/Execution/src/VulkanDevice.cpp
PR 5426 core/libs/prx/libSceAgcDriver/CMakeLists.txt
PR 5431 core/libs/prx/libSceAgcDriver/CMakeLists.txt
core/libs/prx/libSceAgcDriver/Execution/src/Driver/Shaders/ShaderRegistry.cpp
core/libs/prx/libSceAgcDriver/Execution/src/VulkanDevice.cpp
PR 5441 core/libs/prx/libSceAgcDriver/Execution/src/VulkanDevice.cpp
core/libs/prx/libSceAgcDriver/tests/Graphics.cpp
PR 5480 core/libs/prx/libSceAgcDriver/CMakeLists.txt
core/libs/prx/libSceAgcDriver/Execution/src/VulkanDevice.cpp
PR 5499 core/libs/prx/libSceAgcDriver/CMakeLists.txt
core/libs/prx/libSceAgcDriver/Execution/src/VulkanDevice.cpp
core/libs/prx/libSceAgcDriver/tests/Graphics.cpp
PR 5500 core/libs/prx/libSceAgcDriver/tests/Graphics.cpp
PR 5925 core/libs/prx/libSceAgcDriver/CMakeLists.txt
core/libs/prx/libSceAgcDriver/Execution/src/VulkanDevice.cpp
core/libs/prx/libSceAgcDriver/Graphics/src/PipelineLibrary.cpp
core/libs/prx/libSceAgcDriver/tests/Graphics.cpp
PR 6044 core/libs/prx/libSceAgcDriver/CMakeLists.txt
PR 6134 core/libs/prx/libSceAgcDriver/Execution/src/Driver/Shaders/ShaderRegistry.cpp
PR 6177 core/libs/prx/libSceAgcDriver/Execution/src/VulkanDevice.cpp
PR 6188 core/libs/prx/libSceAgcDriver/CMakeLists.txt
core/libs/prx/libSceAgcDriver/Execution/src/Driver/Shaders/ShaderRegistry.cpp
core/libs/prx/libSceAgcDriver/Execution/src/VulkanDevice.cpp
core/libs/prx/libSceAgcDriver/tests/Graphics.cpp
PR 6215 core/libs/prx/libSceAgcDriver/CMakeLists.txt
core/libs/prx/libSceAgcDriver/tests/Graphics.cpp
PR 6222 core/libs/prx/libSceAgcDriver/Execution/src/VulkanDevice.cpp
core/libs/prx/libSceAgcDriver/tests/Graphics.cpp
PR 6235 core/libs/prx/libSceAgcDriver/tests/Graphics.cpp
PR 6259 core/libs/prx/libSceAgcDriver/CMakeLists.txt
core/libs/prx/libSceAgcDriver/Execution/src/VulkanDevice.cpp
PR 6297 core/libs/prx/libSceAgcDriver/tests/Graphics.cpp
PR 6373 core/libs/prx/libSceAgcDriver/CMakeLists.txt
PR 6412 core/libs/prx/libSceAgcDriver/CMakeLists.txt
PR 6503 core/libs/prx/libSceAgcDriver/CMakeLists.txt
core/libs/prx/libSceAgcDriver/Execution/src/VulkanDevice.cpp
PR 6535 core/libs/prx/libSceAgcDriver/CMakeLists.txt
core/libs/prx/libSceAgcDriver/tests/Graphics.cpp
PR 6548 core/libs/prx/libSceAgcDriver/tests/Graphics.cpp
PR 6612 core/libs/prx/libSceAgcDriver/Execution/src/Driver/Shaders/ShaderRegistry.cpp
core/libs/prx/libSceAgcDriver/tests/Graphics.cpp
PR 6718 core/libs/prx/libSceAgcDriver/CMakeLists.txt
core/libs/prx/libSceAgcDriver/Execution/src/VulkanDevice.cpp
PR 6763 core/libs/prx/libSceAgcDriver/CMakeLists.txt
PR 6808 core/libs/prx/libSceAgcDriver/CMakeLists.txt
core/libs/prx/libSceAgcDriver/tests/Graphics.cpp
PR 6937 core/libs/prx/libSceAgcDriver/CMakeLists.txt

@Amoenus

Amoenus commented Oct 16, 2026

Copy link
Copy Markdown
Contributor

@simonbronk @MarcZX100 The updated #6814 already contains this Windows registration correction. I fetched both published heads and verified that #6814 83eb3ed04ae2307f494da08010f123dcb165f861 and this PR 17647ac7f56b4d2ed5fe24efd0d91e792af00103 have the same complete Git tree, edbb564ebdb1bf30b8788d12c972292e5b0368bf; git diff between them is empty.

That is also the exact publishable tree named in this PR's Windows verification report. Those reported Windows results therefore cover the same file contents as the updated parent; this is a source-identity check, not another execution on my machine or a new current-main build claim.

There is no remaining file difference for this follow-up to contribute after #6814. Consolidating into #6814 appears appropriate. No PR or branch was modified by this check.

AI-assisted: Codex; checks performed locally.

@blawesom

Copy link
Copy Markdown
Contributor

Duplicate pair heads-up for the maintainers: this PR and #6814 carry byte-identical diffs (217 lines across the same six files — ShaderRegistry.hpp/.cpp, VulkanDevice.cpp, PipelineLibrary.cpp, the CMakeLists and Graphics.cpp — both adding AwaitLibraryPrebuilds()). #6814 was opened first (13:03 UTC); this one followed 28 minutes later. Whichever survives, the other can be closed as a duplicate — flagging both rather than choosing, since the call is yours.

@oneandonlydean

Copy link
Copy Markdown
Collaborator

Closing in favour of #6814, which carries the same change, including this PR's Windows test fix, and is being tested on current main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

agc libSceAgc* build

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants