Repository navigation
fix(tests): load AGC libraries for the pipeline-clear regression on Windows - #6827
simonbronk wants to merge 2 commits into
Conversation
|
Other open pull requests touch the same code. Merging one will break the other, or both implement the same thing. If this one builds on them, list them in Depends on.
Some comparisons could not be completed because a pull request conflicts with the base branch. Review these shared files manually before concluding that there is no overlap.
|
|
@simonbronk @MarcZX100 The updated #6814 already contains this Windows registration correction. I fetched both published heads and verified that #6814 That is also the exact publishable tree named in this PR's Windows verification report. Those reported Windows results therefore cover the same file contents as the updated parent; this is a source-identity check, not another execution on my machine or a new current-main build claim. There is no remaining file difference for this follow-up to contribute after #6814. Consolidating into #6814 appears appropriate. No PR or branch was modified by this check. AI-assisted: Codex; checks performed locally. |
|
Duplicate pair heads-up for the maintainers: this PR and #6814 carry byte-identical diffs (217 lines across the same six files — |
|
Closing in favour of #6814, which carries the same change, including this PR's Windows test fix, and is being tested on current main. |
What
Follow-up to #6814; please merge it first. Its original commit
81e3db853c00453a04668e2c62e8b969f24d324bis preserved unchanged with its original authorship. Only the final commit is this Windows test-registration correction; until #6814 merges, the diff also contains that PR.The new
agc_pipeline_library_clear_waits_for_buildtest does not receive the Windows DLL search path that its neighbouringagc_pipeline_journaltest uses. On Windows its CTest invocation timed out after 30.02 seconds; launching with the same missing DLL directory exits with0xC0000135. The identical executable succeeds with the directory available.Add the new test to the existing
WIN32PATH property. No runtime or timeout change.Tested
Windows x64, supported WinLibs MinGW-w64 GCC 15.2.0 r7 UCRT, CMake 4.4.4, Release,
BUILD_TESTING=ON, SPIRV-Tools disabled. Current main82ddae75b6761757f3d3ba9c0723647469270f76, parent #681481e3db853c00453a04668e2c62e8b969f24d324b.libSceAgcDriver.prx, dependencies and graphics test executable. No CPU-guard bypass or production instrumentation.agc_driver_graphicsandagc_pipeline_journalpass; the new official regression times out. Two independent mocked-Vulkan controls against the actual DLL pass on fix(agc): drain library prebuilds before device replacement #6814 and fail on main: clear during a library-part creation error and during a final-link error. They also check unrelated-device progress and rebuilding after clear. These controls are provided as an external fixture, not added to this PR.edbb564ebdb1bf30b8788d12c972292e5b0368bfpassesagc_driver_graphics,agc_pipeline_journalandagc_pipeline_library_clear_waits_for_build(3/3). Conventions pass.Checklist
pipeline-lifetime-windows.zip