Repository navigation
Conversation
Zenodeon
marked this pull request as ready for review
October 16, 2026 07:09
|
Some comparisons could not be completed because a pull request conflicts with the base branch. Review these shared files manually before concluding that there is no overlap.
|
11 tasks done
12 tasks done
12 tasks done
Contributor
|
Rebase handoff + one test failure found against current Verified on Linux (CachyOS, kernel 7.2.9, GCC 16.2.1, Ninja, Release,
To pick it up: Head is |
Contributor
|
Re-anchored rebase handoff — The state is unchanged from the earlier report: the PR's own To pick it up: Head is |
12 tasks done
A color view of one slice of a 2D array target refreshed the whole array image before each draw, sampled lookup and present. When the array's unused slices lie over other live targets (ps5-opengl declares every target as a two-slice array and allocates the next one over its second slice), each refresh stored the other targets' pending results, wrote back its own and uploaded the whole image from guest memory again, on every pass. StorageTexture::RefreshLayers refreshes the tracked layers that hold the given array layers alone: it flushes and compares their memory only, and results of other images pending over the other layers stay pending. A layer outside the range whose memory changed or that holds another image's pending results is left behind; GenerationFor reports it as never current, so a use over it takes the whole Refresh. It falls back to Refresh for volumes, single-layer and DCC images, an alias, or results of the image pending outside the range. A draw into an array slice, a 2D view of one layer of an array image and a present of one layer use it. The compare memo of untracked memory is kept per range, so a layer refresh's compare is memoized like the whole image's. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Zenodeon
force-pushed
the
stk-resource-performance-pr
branch
from
October 17, 2026 21:31
3fc42c0 to
619e4c9
Compare
Contributor
Author
|
Thanks for the rebase handoff. I picked it up, retained the original seven commits and authorship, kept main's I reproduced both array failures on Linux/lavapipe with the original assertion intact. The cause was stale The repair checks allocation generation in the epoch map, per-thread ring and shared ring. It retains the original array assertion and adds an uncached-backend precondition.
Your native Linux AMD configuration still needs confirmation; WSL/lavapipe does not qualify that driver. No new gameplay performance claim or evidence-bundle upload. AI-assisted implementation and validation. |
This was referenced Oct 18, 2026
This was referenced Oct 18, 2026
12 tasks done
Contributor
|
Windows and AMD data point: the two new tests pass, and SuperTuxKart is unchanged. Radeon 860M (RDNA 3.5 APU, driver 32.0.13058.8001), Ryzen AI 7 350, Windows 11 26300, WinLibs GCC 15.2.0, Release.
So no FPS change on this scene. That is no evidence either way about the transfers this PR removes, which may not happen in the menu. AI-assisted |
11 tasks done
github-actions
Bot
added
perf
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Scoped texture-array refresh can still perform unnecessary CPU transfers after #6202: its CPU fallback uploads the whole image, and a failed whole-descriptor write collection can erase valid history for an active committed slice.
This PR addresses that resource path in separately reviewable implementation commits:
For uncompressed, single-mip, non-thick 2D arrays with selections covering complete physical layers, read/snapshot, copy, detile and upload only selected layers. Refresh and upload use one eligibility check. Unselected image contents and pending GPU results remain intact. Unsupported layouts and partial physical-layer selections keep the whole-image fallback. Staging/device allocations remain full-sized.
If unused slices include uncommitted memory, preserve generations obtained from successful collections of committed tracked units. Collect the selected scope before examining write stamps and report range-specific generations. Unknown units remain unknown; actual CPU writes still invalidate the affected content. Apply the collection fallback after uploads, clears, copies and write-back settlement.
Expire collection memo hits when the allocation-registry generation changes, in the epoch map, per-thread ring and shared ring. A proof from an earlier mapping at the same address must not hide genuine CPU writes or give an unregistered slice complete history. The direct CPU-write regression covers all three caches and an uncached control.
No title checks, skipped passes, fabricated success, public API changes or shader-semantic changes. W/keyboard configuration is local and excluded.
Dependencies: #6367 and #6202. The first two commits integrate them with attribution; their independent registration/retirement and overlapping-array regressions are retained. #6202 is MiguelAdolfsen's revision
60229fae6469. Our incremental review range is00c0dd3a2...stk-resource-performance-pr, limited to texture handling, its private header, test registration and the array regression. Dependency commits can be dropped as upstream merges them.Upstream overlap rechecked before publication. #6202 supplies scoped refresh but its CPU fallback still uploads the whole array. Related #6273/#6346 optimize write-tracker proofs, #6678 defers import settling, and #6701 changes Windows stamp allocation; those mechanisms are separate. #1191 residency, #6197 import-window changes and the separate write-watch restoration experiment are excluded from this source branch.
Tested
Rebased using blawesom's handoff, preserving the original seven commits and authorship, onto upstream
8f0e276c61086c5192077018910e5dbc04c3a96b. Current PR head:619e4c9c6e281df0a68ce5cd42a364df6de9bf10. The extra commits add a failing collection-history regression, its mapping-generation repair, and an uncached-backend precondition for the existing array fixture. Existinglazy/lazy_synctest modes and dependency regressions are retained.Review failure reproduced and repaired on Linux. Ubuntu 26.04.1 under WSL 2, kernel
6.18.54.1-microsoft-standard-WSL2, GCC 15.2.0, CMake 4.2.3, Release, SPIR-V Tools enabled, bundled dependency revisions. Vulkan: Mesa 26.0.8 lavapipe/llvmpipe, LLVM 21.1.8 (software driver). The production write-watch availability probe passes; none of the tests below skipped.Matched reproduction, before
a26b8d887and repairedd6f654b92, both on upstream084bd39a0:agc_driver_array_layer_targetagc_driver_array_layer_target_cpuagc_collect_mapping_history_mapagc_collect_mapping_history_ringagc_collect_mapping_history_sharedagc_collect_mapping_history_uncachedThe memo cache matched the ordering epoch and unwatch serial but not the allocation registry generation. Mapping replacement in the same epoch could therefore reuse stale write history. The repair requires the registry generation to match in every memo mode. The original array assertion is retained, with an added uncached collection check; no assertion was weakened.
Final-rebase validation at
619e4c9c6:These are correctness results, not new game-performance measurements. The Linux AMD reviewer machine has not been retested here; WSL/lavapipe does not qualify native AMD/NVIDIA driver behavior. #6820's separate native Linux NVIDIA report is outside this update. No shader/residency changes, local input configuration or evidence bundle are included.
Independent Windows AMD validation — LeandroLP23, 2026-10-18. The reviewer tested PR head
619e4c9c6merged cleanly ontomain6efb7261b: Radeon 860M (RDNA 3.5 APU, driver 32.0.13058.8001), Ryzen AI 7 350, Windows 11 26300, WinLibs GCC 15.2.0, Release. Bothagc_driver_array_layer_targetandagc_driver_array_layer_target_cpupassed all three runs; the 14 tests selected byagc_recorder|agc_collect|write_watch|write_history|shared_write|array_layeralso passed.Their SuperTuxKart PPSA69421 00.001.000 performance check measured the menu with no input, 60 seconds per run, using
tools/title_run.pyand presents per second over the whole run. The first run of each build started with an empty AnyPS5 shader cache; both builds ran consecutively on mains power.mainmain+ this PRScene distinction: the reviewer measured the menu; our historical performance measurements below used the Abyss race scene at the starting grid, with Tux, easy difficulty and four karts. The reviewer found no menu FPS improvement and did not measure racing performance. Their results add independent Windows AMD correctness coverage; they neither confirm nor contradict our race-scene measurements, and do not establish whether the menu exercises the selected-layer transfers this PR removes. The hardware, builds and capture windows also differ, so these FPS values must not be compared directly.
Related overlap: #6169 changes which completed tracker generation a concurrent memo hit returns; this repair adds allocation-generation eligibility. The conditions are distinct, and reconciliation must retain both if both changes land. #6759 remains separate.
Historical publication validation: upstream
5d9dcc42d2ec5401aebd089028b8d4d7410a77b4, PR head3fc42c0a221ee93b93acfb7cecb64840c80a3972. Complete Releaselibsand focused test targets rebuilt with GCC 15.2,-O3 -DNDEBUG,BUILD_TESTING=ON, SPIR-V Tools enabled. Windows 10.0.26200, Intel Core i7-13700, 32 GiB RAM, NVIDIA RTX 4070 12 GiB, driver 591.86. Complete runtime snapshots record source/dependency revisions, flags and SHA-256 hashes.At publication: 16/16 focused tests pass in 20.02 seconds, each under 30 seconds. Conventions and diff checks pass. These tests cover array layers with host imports enabled/disabled, retained units, upload lifetime/failure, split write-back, host-import retirement, CPU snapshots, graphics, depth clears/storage/reuse, one-slice aliasing, write-back overhang and write-watch coverage. Linux/lavapipe was untested at publication; the new Linux results are recorded above. Native AMD/Intel hardware remains untested locally.
Pre-fix evidence from the preserved regression runs (included with logs):
The array tests check first/last active slices, untouched neighboring GPU results, subsequent alias reads, genuine CPU writes, repeated unchanged refreshes, pending-result retention and image version. #6367's separate unregistered-unused-slice and retirement cases remain present. Existing graphics/resource tests exercise broader layouts; targeted exhaustive coverage of every unsupported-layout combination is not claimed.
Gameplay measurements below are historical equivalent integration builds, not measurements of the rebased head or bare current
main. They compare both our resource changes together. Baselineebc89db25587and candidate791d12671372hold #6367, #6202's original3a39b6cfdimplementation, and Scott Schuster/TheAggie's rendering experiment45944fbbe0dcconstant. The updated #6202 revision adapts the newer upstream API; current-head game measurements must be repeated before readiness. No dependency or shader improvement is credited to this PR.SuperTuxKart PPSA69421: Abyss starting grid, Tux, easy, four karts, 1920x1080, identical settings/configuration, same machine/session. Three alternating baseline/candidate pairs, warmed caches and separate restarts, 60-second lead-in, 120-second window, no input, inherited game logs. Only
APS5_TRACE_SECONDS=60:120enabled for acceptance captures.The candidate remains around 8 FPS; it is not smooth gameplay. Baseline variability remains unexplained. A repeatable 20% gain is not established: pair 1 improves only 5.60%. The larger pairwise gains must not be presented alone as representative.
All six frame windows and runtime hashes were verified. Long detailed event timelines overflowed; independently recorded frame timestamps/percentiles and phase totals remained complete.
trace_droppedis retained in the summary lines. Complete separate 10-second diagnostics attribute the mechanism: adding the history fix to the selected-layer runtime reduces upload waits from 5 to 2/frame and refresh write-back waits from 3 to 0/frame; median 160.132 to 138.795 ms. Measured GPU batches including synchronous work fall from 45.884 to 37.730 ms/frame. Recorded-only summary GPU numbers omit synchronous fallback batches; nested/concurrent CPU/GPU costs must not be added.The preserved candidate integration completed 900.578 seconds of automatic driving across multiple laps, with sampled scenery correct and no matched fatal/assertion/device-loss signatures. A clean finite race finish is not a pass: baseline and candidate both exit
0xc0000409; baseline debugging reachedLibcException::DefaultTerminate()/abort(), with the underlying exception unresolved. vkQuake produced no frames in either 40-second startup check, so cross-title rendering is inconclusive. Controls/audio were previously user-confirmed on the integration; fresh confirmation on this rebased head is pending.The rendering experiment is absent from the PR source. It has a known flat-interpolation semantic-test failure in game integrations; the publishable source graphics test passes, and no semantic guard was weakened. The 15-minute integration check does not validate that separate shader experiment's semantics.
Evidence: the six original acceptance summary lines are included below. Full trace files, trace-digest reports and SHA-256 digests, runtime manifests, pre-fix failure logs and fresh correctness results are packaged locally in an 18.37 MiB review bundle; the bundle is retained locally and has not been uploaded, at the author's request. No game assets or binaries are included. Full trace evidence is not publicly attached.
Original acceptance summary lines, pairs 1-3 (baseline then candidate)
{"commit":"ebc89db25587","dirty":false,"env":{"APS5_PAD_INPUT_FILE":"<path>","APS5_TRACE_SECONDS":"60:120"},"gpu":"NVIDIA GeForce RTX 4070","driver":"NVIDIA 591.86","os":"Windows 10.0.26200","resolution":"1920x1080","window":{"spec":"seconds 60:120","first_present":338,"ms":120006.155},"presents":901,"frame_ms":{"p50":136.931,"p90":160.672,"p99":166.014,"max":203.87},"gpu_busy_ms_per_present":10.172,"worker_busy_pct":{"queue worker 0x0":15.862},"top_phases_ms_per_frame":{"Driver.EndSubmission":10.875,"Driver.Packet":10.245,"Driver.Packet.draw":8.345,"Driver.Draw":8.288,"Driver.Draw.draw_enqueued":5.677,"Driver.Draw.shader_compile_and_link":2.082,"Shader.DrawStage":1.231,"Shader.DrawStage.capture_resources":0.736},"trace_dropped":true,"trace_dropped_threads":{"queue worker 0x0":{"events_full_after_s":72.903,"events_lost":149219,"totals_full":false}},"trace":"aps5-trace-ebc89db25587-39984.json.gz"} {"commit":"791d12671372","dirty":false,"env":{"APS5_PAD_INPUT_FILE":"<path>","APS5_TRACE_SECONDS":"60:120"},"gpu":"NVIDIA GeForce RTX 4070","driver":"NVIDIA 591.86","os":"Windows 10.0.26200","resolution":"1920x1080","window":{"spec":"seconds 60:120","first_present":392,"ms":120077.139},"presents":952,"frame_ms":{"p50":123.868,"p90":136.366,"p99":142.151,"max":153.52},"gpu_busy_ms_per_present":11.698,"worker_busy_pct":{"queue worker 0x0":10.584},"top_phases_ms_per_frame":{"Driver.Packet":12.569,"Driver.Packet.draw":8.278,"Driver.Draw":8.223,"Driver.Draw.draw_enqueued":5.476,"Driver.Draw.shader_compile_and_link":2.223,"Shader.DrawStage":1.399,"Shader.DrawStage.capture_resources":0.796,"Driver.EndSubmission":0.775},"trace_dropped":true,"trace_dropped_threads":{"queue worker 0x0":{"events_full_after_s":64.349,"events_lost":200185,"totals_full":false}},"trace":"aps5-trace-791d12671372-55468.json.gz"} {"commit":"ebc89db25587","dirty":false,"env":{"APS5_PAD_INPUT_FILE":"<path>","APS5_TRACE_SECONDS":"60:120"},"gpu":"NVIDIA GeForce RTX 4070","driver":"NVIDIA 591.86","os":"Windows 10.0.26200","resolution":"1920x1080","window":{"spec":"seconds 60:120","first_present":267,"ms":120050.913},"presents":623,"frame_ms":{"p50":188.031,"p90":198.624,"p99":295.121,"max":299.775},"gpu_busy_ms_per_present":9.824,"worker_busy_pct":{"queue worker 0x0":21.551},"top_phases_ms_per_frame":{"Driver.EndSubmission":29.752,"Driver.Packet":11.769,"Driver.Packet.draw":8.613,"Driver.Draw":8.557,"Driver.Draw.draw_enqueued":5.662,"Driver.Draw.shader_compile_and_link":2.366,"GpuMutex.wait.flush":1.585,"Shader.DrawStage":1.529},"trace_dropped":true,"trace_dropped_threads":{"queue worker 0x0":{"events_full_after_s":93.655,"events_lost":56162,"totals_full":false}},"trace":"aps5-trace-ebc89db25587-33172.json.gz"} {"commit":"791d12671372","dirty":false,"env":{"APS5_PAD_INPUT_FILE":"<path>","APS5_TRACE_SECONDS":"60:120"},"gpu":"NVIDIA GeForce RTX 4070","driver":"NVIDIA 591.86","os":"Windows 10.0.26200","resolution":"1920x1080","window":{"spec":"seconds 60:120","first_present":361,"ms":120051.935},"presents":972,"frame_ms":{"p50":118.283,"p90":140.11,"p99":144.278,"max":148.017},"gpu_busy_ms_per_present":11.672,"worker_busy_pct":{"queue worker 0x0":8.674},"top_phases_ms_per_frame":{"Driver.Packet":10.019,"Driver.Packet.draw":8.225,"Driver.Draw":8.172,"Driver.Draw.draw_enqueued":5.708,"Driver.Draw.shader_compile_and_link":1.97,"Shader.DrawStage":1.19,"Shader.DrawStage.capture_resources":0.72,"Driver.EndSubmission":0.688},"trace_dropped":true,"trace_dropped_threads":{"queue worker 0x0":{"events_full_after_s":68.984,"events_lost":183536,"totals_full":false}},"trace":"aps5-trace-791d12671372-51232.json.gz"} {"commit":"ebc89db25587","dirty":false,"env":{"APS5_PAD_INPUT_FILE":"<path>","APS5_TRACE_SECONDS":"60:120"},"gpu":"NVIDIA GeForce RTX 4070","driver":"NVIDIA 591.86","os":"Windows 10.0.26200","resolution":"1920x1080","window":{"spec":"seconds 60:120","first_present":252,"ms":120078.225},"presents":583,"frame_ms":{"p50":199.604,"p90":215.177,"p99":307.007,"max":314.4},"gpu_busy_ms_per_present":10.816,"worker_busy_pct":{"queue worker 0x0":19.529},"top_phases_ms_per_frame":{"Driver.EndSubmission":27.794,"Driver.Packet":12.423,"Driver.Packet.draw":9.623,"Driver.Draw":9.558,"Driver.Draw.draw_enqueued":6.488,"Driver.Draw.shader_compile_and_link":2.469,"GpuMutex.wait.flush":2.018,"Shader.DrawStage":1.54},"trace_dropped":true,"trace_dropped_threads":{"queue worker 0x0":{"events_full_after_s":93.336,"events_lost":69182,"totals_full":false}},"trace":"aps5-trace-ebc89db25587-49216.json.gz"} {"commit":"791d12671372","dirty":false,"env":{"APS5_PAD_INPUT_FILE":"<path>","APS5_TRACE_SECONDS":"60:120"},"gpu":"NVIDIA GeForce RTX 4070","driver":"NVIDIA 591.86","os":"Windows 10.0.26200","resolution":"1920x1080","window":{"spec":"seconds 60:120","first_present":352,"ms":120085.693},"presents":954,"frame_ms":{"p50":120.602,"p90":144.078,"p99":148.899,"max":152.774},"gpu_busy_ms_per_present":11.716,"worker_busy_pct":{"queue worker 0x0":12.609},"top_phases_ms_per_frame":{"Driver.Packet":10.967,"Driver.Packet.draw":8.099,"Driver.Draw":8.046,"Driver.Draw.draw_enqueued":5.38,"Driver.EndSubmission":4.898,"Driver.Draw.shader_compile_and_link":2.154,"Shader.DrawStage":1.345,"Shader.DrawStage.capture_resources":0.771},"trace_dropped":true,"trace_dropped_threads":{"queue worker 0x0":{"events_full_after_s":65.201,"events_lost":180884,"totals_full":false}},"trace":"aps5-trace-791d12671372-52320.json.gz"}Checklist
main; no other open PR implements the same functionsNotImplemented_nid_no_patch); silent stubs are listed under Silent stubs in their library's technical debt file.mdfiles or images added to the repository (attach them to this PR)Remaining validation: dependency reconciliation, fresh current-head gameplay comparisons, cross-title validation and investigation of the finite-race exit failure. Marked ready for review at the author's request; these gaps remain unresolved. No black-rendering, 30-FPS or repeatable-20%-gain claim.
Separate follow-up: partial-page write-watch restoration
A standalone correctness follow-up is published: restore write-watch coverage for remapped pages. It restores CPU-write tracking for complete 4 KiB private remappings inside an excluded 64 KiB import block, preserving neighboring exclusions and stale-generation checks. It has no dependency on this PR and includes no residency or shader changes.
Separately, a local integration of this PR, that repair and #1191's opt-in linear-target residency was evaluated with the same shader revision held constant. Three alternating 120-second residency-off/on pairs averaged 8.35/10.99, 8.20/10.80 and 8.38/11.27 FPS. These local results isolate the residency toggle: the 31.6–34.4% gain belongs to #1191's residency work and is not an additional gain claimed by this PR or by the write-watch repair. Detailed long event timelines overflowed; frame windows were complete, and separate complete short diagnostics showed the three synchronous draw waits disappear.
Clean-source integration passes 18 focused tests with residency off/on. Both automated one-lap races exit cleanly. The extended run has incomplete screenshot coverage, and vkQuake startup remains inconclusive. The playable shader experiment retains its known semantic-test failure and is excluded from publishable source. These residency measurements predate the review repair above and remain separate from this PR's original performance evidence.