Repository navigation
Conversation
This was referenced Oct 15, 2026
|
Other open pull requests touch the same code. Merging one will break the other, or both implement the same thing. If this one builds on them, list them in Depends on.
Some comparisons could not be completed because a pull request conflicts with the base branch. Review these shared files manually before concluding that there is no overlap.
|
Author
|
Closing as a duplicate. #6170 (opened earlier) already implements |
primesoul-web
added a commit
to primesoul-web/AnyPS5
that referenced
this pull request
Oct 15, 2026
…ing states layout guest_gameupdate still asserted the throw that sceGameUpdateGetAddcontLatestVersion no longer raises for a null entitlement label since it answers 0x80412803, so the test aborts; it now asserts the error, the same change boykopovar#5919 makes. The mastering states layout is pinned with compile-time size checks for the descriptors, the compressor and limiter states and both states structs, as boykopovar#6380 suggested.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Implements
sceAudioOut2MasteringGetState, which threwNotImplemented_nid_no_patch. States id 1 (default, three compressor bands) and 2 (V2, four bands) return a zeroed state with the states id, compressor descriptor (0x01010001 / 0x01020001) and limiter descriptor (0x01010003) set. A null pointer returns 0x80268201 and an unknown id 0x80268204. The layouts, ids and error codes follow KytyPS5src/libs/libAudio2.cpp(GPL-2.0); the code is written from scratch. The behaviour is unverified on a console and recorded indocs/dev/debt/libSceAudioOut.md.Tested
BUILD_TESTING=ON:audio_out2_latency(newTestMasteringGetStateplus compile-time size checks, 336 and 400 bytes) and all 23 audio tests pass. The new test fails on the old stub.python3 tools/check_conventions.py --base origin/mainpasses.VZidxi2cYh0), is converted with the relinker and run against the builtlibSceAudioOut.prx. It checks the return value, ids, descriptor sizes and zeroed fields for both states ids; a control with a wrong expected id fails.librariesprogress: 3272/3689 to 3273/3689.Checklist
main; no other open PR implements the same functionsNotImplemented_nid_no_patch); silent stubs are listed under Silent stubs in their library's technical debt file.mdfiles or images added to the repository (attach them to this PR)🤖 Generated with Claude Code