Skip to content

fix(libSceAcm): silent stub for sceAcmBatchJobPriority - #6274

Closed
mazen320 wants to merge 2 commits into
boykopovar:mainfrom
mazen320:fix/acm-batch-job-priority-silent-stub
Closed

mazen320 wants to merge 2 commits into
boykopovar:mainfrom
mazen320:fix/acm-batch-job-priority-silent-stub

Conversation

@mazen320

Copy link
Copy Markdown
Contributor

What

sceAcmBatchJobPriority no longer calls NotImplemented_nid_no_patch. It returns 0 with no batch-job priority state.

PPSA02530 imports it with an unknown signature and stops when it throws. Debt moved into Silent stubs; the co-listed scePadVrControllerGetTriggerEffectStates note moves to libScePad debt (still throwing). guest_acm covers the new return.

Tested

Windows 11. python tools/check_conventions.py --base upstream/main passed. Full guest_acm run needs a configure that rebuilds libSceAcm against this worktree (not re-run here against the dirty main build tree).

Checklist

  • Based on current main; no other open PR implements the same functions
  • One topic per PR; follow-ups go in a new PR
  • No comments in code except technical debt
  • Unimplemented paths throw (NotImplemented_nid_no_patch); silent stubs are listed under Silent stubs in their library's technical debt file
  • No notes, investigation .md files or images added to the repository (attach them to this PR)
  • New third-party code is a submodule built from source
  • Generic behaviour, not specific to one title
  • Depends on: none
  • Unblocks: PPSA02530 (BatchJobPriority stop; Pad TriggerEffectStates remain)
  • GPUs tested: n/a
  • AI-assisted: yes

PPSA02530 stops when the unknown-signature import throws; return 0 with no
batch-job priority and list it under Silent stubs.
@github-actions

Copy link
Copy Markdown

Progress report (2baae7a → a2237f8)

📈 System libraries: 88.74% (+0.03%, +1 implemented functions)

✅ 1 implemented
Library Name
libSceAcm sceAcmBatchJobPriority
⚪ 1 behaviourally empty (constant return or throw)
Library Name
libSceAcm sceAcmBatchJobPriority

@github-actions

github-actions Bot commented Oct 15, 2026 •

Copy link
Copy Markdown

Other open pull requests touch the same code. Merging one will break the other, or both implement the same thing. If this one builds on them, list them in Depends on.

Pull request Conflicting files (lines on main) Same exports Same new files
PR 5676 docs/dev/debt/libScePad.md L4

Some comparisons could not be completed because a pull request conflicts with the base branch. Review these shared files manually before concluding that there is no overlap.

Pull request Shared files not compared
PR 5038 docs/dev/debt/libScePad.md
PR 6044 core/libs/tests/GuestAcm.cpp

@mazen320

Copy link
Copy Markdown
Contributor Author

Overlap

Bot flagged debt adjacency with #5676 (docs/dev/debt/libScePad.md). This PR is Acm sceAcmBatchJobPriority only — different library. Depends on: none.

@MarcZX10 MarcZX10 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The contribution guide currently allows silent stubs only when they unblock a title and affect only the UI. This export is in libSceAcm, and returning success without setting any batch-job priority also skips audio behavior. The issue establishes that the import prevents loading, but it does not establish that this operation is UI-only or safe to ignore. Could you add evidence for that behavior, or keep the export throwing until its contract is known? Listing it under Silent stubs documents the limitation but does not establish that the exception applies.

@mazen320

Copy link
Copy Markdown
Contributor Author

Agree — sceAcmBatchJobPriority is Acm audio scheduling, not UI-only, so it does not meet the CONTRIBUTING silent-stub exception.

Restored NotImplemented_nid_no_patch and the Unknown function info debt note (cc854e9). Closing this PR; will keep it throwing until the contract is known or there is UI-only evidence.

@mazen320

Copy link
Copy Markdown
Contributor Author

Closing: silent stub withdrawn per review; export throws again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants