Repository navigation
Conversation
PPSA02530 stops when the unknown-signature import throws; return 0 with no batch-job priority and list it under Silent stubs.
|
Other open pull requests touch the same code. Merging one will break the other, or both implement the same thing. If this one builds on them, list them in Depends on.
Some comparisons could not be completed because a pull request conflicts with the base branch. Review these shared files manually before concluding that there is no overlap.
|
OverlapBot flagged debt adjacency with #5676 ( |
MarcZX10
left a comment
There was a problem hiding this comment.
The contribution guide currently allows silent stubs only when they unblock a title and affect only the UI. This export is in libSceAcm, and returning success without setting any batch-job priority also skips audio behavior. The issue establishes that the import prevents loading, but it does not establish that this operation is UI-only or safe to ignore. Could you add evidence for that behavior, or keep the export throwing until its contract is known? Listing it under Silent stubs documents the limitation but does not establish that the exception applies.
This reverts commit a2237f8.
|
Agree — Restored |
|
Closing: silent stub withdrawn per review; export throws again. |
What
sceAcmBatchJobPriorityno longer callsNotImplemented_nid_no_patch. It returns 0 with no batch-job priority state.PPSA02530 imports it with an unknown signature and stops when it throws. Debt moved into Silent stubs; the co-listed
scePadVrControllerGetTriggerEffectStatesnote moves to libScePad debt (still throwing).guest_acmcovers the new return.Tested
Windows 11.
python tools/check_conventions.py --base upstream/mainpassed. Fullguest_acmrun needs a configure that rebuildslibSceAcmagainst this worktree (not re-run here against the dirty main build tree).Checklist
main; no other open PR implements the same functionsNotImplemented_nid_no_patch); silent stubs are listed under Silent stubs in their library's technical debt file.mdfiles or images added to the repository (attach them to this PR)