Repository navigation
test(agc): disable the shader disk cache in agc_shader_memory_tests - #6109
Merged
adriadam10 merged 1 commit intoOct 18, 2026
Merged
adriadam10 merged 1 commit into
adriadam10 merged 1 commit into
Conversation
This was referenced Oct 15, 2026
|
Some comparisons could not be completed because a pull request conflicts with the base branch. Review these shared files manually before concluding that there is no overlap.
|
This was referenced Oct 15, 2026
Closed
Collaborator
|
Checked: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fixes #6076.
The failure is not NVIDIA-specific.
agc_shader_memory_testsuses the shader disk cache when it is run directly, because only the CTest registrations setANYPS5_NO_SHADER_CACHE=1. The first direct run passes and writestests/shader_cache. On every later runfindOrCompileVariantloads the variants from that cache instead of building a resource program, soResourcePrograms()is 0 and the layout pair check fails with "the second layout ignored the reuse switch". CI never sees it because CTest disables the cache.mainnow setsANYPS5_NO_SHADER_CACHE=1before any test runs, astests/Mesh.cppalready does, so a direct run behaves like the CTest one.Tested
Arch Linux, GCC, Release, NVIDIA RTX 3050 Laptop (the test does not use the GPU).
ANYPS5_SHADER_CACHE_DIRpointing at an empty directory,agc_shader_memory_tests --layout-pairpasses on the first run and fails on the second and third with the message from the issue. WithANYPS5_NO_SHADER_CACHE=1it passes every time.--layout-pair,--frontend-pairand the no-argument run pass repeatedly against the warm cache directory and from the default location; noshader_cachedirectory is created next to the binary.ctest -R 'agc_shader_(memory|bindless|srt_read_patching|frontend_pair|layout_pair)': 7/7 passed.python3 tools/check_conventions.py --base origin/main: passed.Checklist
main; no other open PR implements the same functionsNotImplemented_nid_no_patch); silent stubs are listed under Silent stubs in their library's technical debt file.mdfiles or images added to the repository (attach them to this PR)