Repository navigation
feat(libScePlayerSelectionDialog): run common-dialog state machine without UI - #6058
Conversation
…thout UI Co-authored-by: Cursor <cursoragent@cursor.com>
Progress report (55f82fe → 784cb4d)📈 System libraries: 89.67% (+0.01%, +4 implemented functions) ✅ 4 implemented
|
|
Other open pull requests touch the same code. Merging one will break the other, or both implement the same thing. If this one builds on them, list them in Depends on.
|
|
Tested on Linux x86-64 (Release build), with 784cb4d merged into main e16b2bc:
AI-assisted: yes (Claude Code) |
|
Closing to free intake for PPSA03541 pixel interpolator DEFAULT coverage fix. |
|
FC 25 (PPSA20049, 01.000.028) imports the same four exports (DrDfu7uq6JY Initialize, 9Oj3MIJ+Zjk Open, PBmrW72wbPQ UpdateStatus, GtF-2gJqsts GetResult) and doesn't load on current main (66702f1) without them. With this PR merged locally, plus #6343, it loads, and with two local AGC fixes it reaches its title screen. Up to the title screen and pressing Start it never calls any of the five PlayerSelectionDialog functions (gdb dprintf on each), so there only the exports are needed. Would you reopen it now that #6034, #6049, #6056 and #6062 are merged? If you don't plan to, I can open a PR with only these four exports and FC 25 as the title; tell me which you prefer. AI-assisted: yes |
|
A third title needs these four exports: SWORD ART ONLINE Last Recollection (PPSA06958, 01.021.000, Unreal Engine 4). On main (66702f1) it stops at load: These are scePlayerSelectionDialogUpdateStatus, Initialize, Open and GetResult. With this PR's commit (784cb4d) cherry-picked onto main 66702f1, the title loads, shows its start-up logos and reaches its menu. It then stops with an unrelated crash in FAsyncLoadingThread (illegal instruction at app.exe+0x2027a2c), which this PR does not touch. Windows 11, WinLibs GCC 15.2.0, RTX 5090. With PPSA34015 and hugodearaujo's PPSA20049 that makes three titles that cannot load without these exports. Could this be reopened? If not, I can open a PR with only the four exports and these titles as the stuck ones; tell me which you prefer. AI-assisted: yes. Written with AI assistance and reviewed by me. |
What
PPSA34015 (EA SPORTS FC 27), after LoginService / NpPartner001 / NpManager exports, fails to load
libScePlayerSelectionDialog.prx:The eboot also imports
Initialize,OpenandUpdateStatus. OnlyTerminateexisted. The four missing exports now followlibSceLoginDialog: initialize, open finishes immediately,GetResultwritesUSER_CANCELEDas the firstint32, terminate clears state. Silent stub underdocs/dev/debt/libScePlayerSelectionDialog.md. The rest of the result layout (player list) is not filled.Tested
Windows 10, WinLibs GCC 15.2.0,
guest_player_selection_dialogpasses. With the patched.prx(stacked on the earlier PPSA34015 libs) the title no longer reportsGtF-2gJqsts; the next loader stop isAAMM-Q1X0g0fromlibSceVdecsw.prx(separate).tools/check_conventions.py --base upstream/mainpasses.Checklist
main; no other open PR implements the same functionsNotImplemented_nid_no_patch); silent stubs are listed under Silent stubs in their library's technical debt file.mdfiles or images added to the repository (attach them to this PR)Made with Cursor