Repository navigation
test(agc): word the lavapipe skips of two tests as device limitations - #5805
Merged
Merged
Conversation
Co-Authored-By: Claude <noreply@anthropic.com>
11 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Main's linux job fails
check_skipssince #4451 and #5520 (run 38556304009):agc_driver_dithered_alpha_to_coverageandagc_shadowed_key_storesskip on lavapipe with messages the device-limitation pattern oftools/check_skips.pydoesn't match. Both skips are device limitations (no eight-sample color attachments; no watched host import under a unit shadow), so their messages now use the pattern's wording (the device lacks,the device imports no).Tested
Linux: both new messages match
DEVICE_LIMITATION; no other reference to the old texts.Checklist
main; no other open PR implements the same functionsNotImplemented_nid_no_patch); silent stubs are listed under Silent stubs in their library's technical debt file.mdfiles or images added to the repository (attach them to this PR)