Skip to content

fix(conventions): accept Depends on answered as a list - #5765

Merged
adriadam10 merged 1 commit into
boykopovar:mainfrom
GalaxyGamingFR:fix/conventions-depends-on-list
Oct 15, 2026
Merged

adriadam10 merged 1 commit into
boykopovar:mainfrom
GalaxyGamingFR:fix/conventions-depends-on-list

Conversation

@GalaxyGamingFR

Copy link
Copy Markdown
Contributor

What

The pr-template check in tools/check_conventions.py only accepted Depends on: #N or none on the same line. A checklist that answers it as a bulleted list, e.g.

- [x] Depends on:
  - #3
  - #4

failed CI, although tools/pr_overlap.py parses exactly that form on purpose (test_pr_overlap_dependencies.py covers it). The pattern now allows one list marker (-, * or +) before the first answer. An empty answer followed by the next checklist item is still reported.

Tested

Windows 11, Python 3.12. No C++ changes.

  • tools/tests/test_check_conventions_comments.py: new test_depends_on_answered_as_a_list_is_accepted (4 subtests: LF, CRLF, unindented, * none) fails on main and passes with this change; new test_depends_on_left_empty_before_the_next_item_is_reported passes on both.
  • the tests live in the tool's existing test file, so CMakeLists.txt is unchanged.
  • every tools/tests/test_*.py passes; python -I tools/check_conventions.py --base origin/main passes.

Checklist

  • Based on current main; no other open PR implements the same functions
  • One topic per PR; follow-ups go in a new PR
  • No comments in code except technical debt
  • Unimplemented paths throw (NotImplemented_nid_no_patch); silent stubs are listed under Silent stubs in their library's technical debt file
  • No notes, investigation .md files or images added to the repository (attach them to this PR)
  • New third-party code is a submodule built from source
  • Generic behaviour, not specific to one title
  • Depends on: none
  • Unblocks: none
  • GPUs tested: n/a
  • AI-assisted: yes

🤖 Generated with Claude Code

https://claude.ai/code/session_012zyXkUzTZGh3nBwNMtrLaW

The pr-template check only accepted "Depends on: #N" or "none" on the same
line, so a checklist answering it as a bulleted list failed CI although
pr_overlap reads exactly that form (test_pr_overlap_dependencies covers
"Depends on:
- boykopovar#2
- boykopovar#3"). Allow one list marker before the first answer;
an empty answer is still reported.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_012zyXkUzTZGh3nBwNMtrLaW
@github-actions

Copy link
Copy Markdown

Some comparisons could not be completed because a pull request conflicts with the base branch. Review these shared files manually before concluding that there is no overlap.

Pull request Shared files not compared
#5780 tools/check_conventions.py

@adriadam10

Copy link
Copy Markdown
Collaborator

Checked the regex change in tools/check_conventions.py: the 4 new list subtests fail with main's checker and pass with this one, the empty-answer case is still reported, and the full test_check_conventions_comments module (61 tests) passes; merging.

@adriadam10
adriadam10 merged commit b08db6a into boykopovar:main Oct 15, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants