Repository navigation
fix(conventions): accept Depends on answered as a list - #5765
Merged
adriadam10 merged 1 commit intoOct 15, 2026
Merged
Conversation
The pr-template check only accepted "Depends on: #N" or "none" on the same line, so a checklist answering it as a bulleted list failed CI although pr_overlap reads exactly that form (test_pr_overlap_dependencies covers "Depends on: - boykopovar#2 - boykopovar#3"). Allow one list marker before the first answer; an empty answer is still reported. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012zyXkUzTZGh3nBwNMtrLaW
|
Some comparisons could not be completed because a pull request conflicts with the base branch. Review these shared files manually before concluding that there is no overlap.
|
11 tasks done
Collaborator
|
Checked the regex change in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The
pr-templatecheck intools/check_conventions.pyonly acceptedDepends on: #Nornoneon the same line. A checklist that answers it as a bulleted list, e.g.failed CI, although
tools/pr_overlap.pyparses exactly that form on purpose (test_pr_overlap_dependencies.pycovers it). The pattern now allows one list marker (-,*or+) before the first answer. An empty answer followed by the next checklist item is still reported.Tested
Windows 11, Python 3.12. No C++ changes.
tools/tests/test_check_conventions_comments.py: newtest_depends_on_answered_as_a_list_is_accepted(4 subtests: LF, CRLF, unindented,* none) fails onmainand passes with this change; newtest_depends_on_left_empty_before_the_next_item_is_reportedpasses on both.CMakeLists.txtis unchanged.tools/tests/test_*.pypasses;python -I tools/check_conventions.py --base origin/mainpasses.Checklist
main; no other open PR implements the same functionsNotImplemented_nid_no_patch); silent stubs are listed under Silent stubs in their library's technical debt file.mdfiles or images added to the repository (attach them to this PR)🤖 Generated with Claude Code
https://claude.ai/code/session_012zyXkUzTZGh3nBwNMtrLaW