Repository navigation
fix(libSceAjm.native): reject a null batch buffer list with a nonzero count - #5639
Closed
klosixgaming-arch wants to merge 1 commit into
Closed
klosixgaming-arch wants to merge 1 commit into
klosixgaming-arch wants to merge 1 commit into
Conversation
… count Every batch job appends through the same helper, which reported a null input or output buffer list with a nonzero count as unimplemented. The list the count promises does not exist, so this is a caller error: it now throws std::invalid_argument without writing to the batch, as other invalid arguments of the library do. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Dh1MhYBFyzxRceoAxrepZ6
Progress report (91e5f60 → 2e5b4f4)📈 System libraries: 88.38% (+0.19%, +7 implemented functions) ✅ 7 implemented
|
Collaborator
|
Closing: no title is known to reach this. With the queue at 700+ open PRs, please hold off on new PRs that don't name a title needing the change until it's down. If a title stops on this on current main, reopen with the title ID and the log line. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Every batch job appends through
Append, which reported a null input or output buffer list with a nonzero count as unimplemented. The list the count promises does not exist, so that is a caller error rather than missing behaviour: it now throwsstd::invalid_argumentwithout writing to the batch, like the library's other invalid arguments. SinceAppendno longer reachesNotImplemented_nid_no_patch, the seven exports that only build jobs through it (sceAjmBatchJobInitialize,ClearContext,SetGaplessDecode,RunSplit,GetResampleInfo,SetResampleParameters,GetStatistics) count as implemented (libSceAjm.native 21 to 28 of 35).The existing test expected
std::runtime_error; it now expectsstd::invalid_argumentfor a null input list and a null output list, and checks that a null list with a zero count is still accepted. No changed line overlaps #4934, #5075, #5307 or #5517.Tested
Linux (Ubuntu 24.04, GCC 13.3, Release): built the library and its test target,
ctest -R guest_ajmpasses,tools/check_conventions.py --base origin/mainpasses. No title tested.Checklist
main; no other open PR implements the same functionsNotImplemented_nid_no_patch); silent stubs are listed under Silent stubs in their library's technical debt file.mdfiles or images added to the repository (attach them to this PR)🤖 Generated with Claude Code
https://claude.ai/code/session_01Dh1MhYBFyzxRceoAxrepZ6