Repository navigation
feat(libc): implement x87 long-double finite classification - #5599
Merged
Merged
Conversation
This was referenced Oct 14, 2026
11 tasks done
This was referenced Oct 14, 2026
Closed
Collaborator
|
Checked |
This was referenced Oct 15, 2026
|
Some comparisons could not be completed because a pull request conflicts with the base branch. Review these shared files manually before concluding that there is no overlap.
|
This was referenced Oct 15, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Implement
__isfinitel(NID3-zCDXatSU4), imported by Astro Bot PPSA21564's bundled PSML module. Classify the x87 exponent directly: return 1 for finite values and 0 for infinities/NaNs, without narrowing to double or performing floating-point comparisons. Require the existing little-endian, 16-byte x87 long-double representation.The signature/classification follows FreeBSD msun; console behavior is unmeasured and recorded in library debt.
Tested
665136f53ef5, containing maind1670009fbfd: Linux 1,037 passed / 46 skipped; Windows 714 passed / 389 skipped. Expected skips remain unvalidated.ce5c8395333; full CI remains tied to its recorded source/base. Conventions and whitespace checks pass.Checklist
Current review refresh: head
2f9d04fb77ffe4880e56e3548d78443c1395ad2bincludes upstream maina5f493f90dca348a65561aed4bb325a629d1b668. Conflicts are resolved and current conventions pass. Earlier full-build results describe the earlier head; fresh full Linux/Windows checks for this head are pending.Verified current full CI: run 38505264035 passes topic
2f9d04fb77ffe4880e56e3548d78443c1395ad2bmerged into basea5f493f90dca348a65561aed4bb325a629d1b668. Linux 1059 passed/46 expected skips; Windows 730 passed/397 expected skips. Skipped cases remain unvalidated. The tested source tree matches this published topic head.