Repository navigation
feat(videoout): expose buffer labels and release replaced frames - #5592
Merged
Merged
Conversation
…eoout-buffer-labels
…eoout-buffer-labels
Collaborator
|
Checked the label array against shadPS4 and fpPS4 (null output, invalid handle, count 16), the registration reset and the release of the previous buffer on replacement/black/blank flips. Built and ran |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Implement
sceVideoOutGetBufferLabelAddresswith a port-owned array of 16 aligned 64-bit labels. Return its address and count, reset newly registered slots, and release the previous displayed buffer's label when its replacement completes presentation. Black/blank replacements release the previous buffer without using a negative index. Ports and reopened generations have separate arrays.Route stores through a graphics-driver helper retained by production NID patching, so the memory tracker observes an atomic release store. Failed handle/pointer queries preserve output, and successful pointer output supports unaligned storage.
Astro Bot PPSA21564's bundled driver uses a pointer output and
base + index * 8. Count and release behavior follow shadPS4 and its driver. PS5 timing, error policy, repeated same-buffer flips and concurrent guest stores remain unverified and documented in library debt. This does not implement EOP-flip tokens, which are separate work in #5539.Tested
d1de55fb3306, containing maind1670009fbfd: Linux 1,037 passed / 48 skipped; Windows 714 passed / 391 skipped. Display-dependent label cases are skipped on these runners and remain outside CI's functional validation.feddf7f4c654; the full CI above remains tied to its recorded earlier source/base. Conventions and whitespace checks pass.Checklist