Repository navigation
fix(videoout): disable SDL DirectInput joystick enumeration on Windows - #5580
Merged
oneandonlydean merged 2 commits intoOct 14, 2026
Merged
Conversation
Co-authored-by: Tenith01 <102300949+Tenith01@users.noreply.github.com>
This was referenced Oct 14, 2026
|
Other open pull requests touch the same code. Merging one will break the other, or both implement the same thing. If this one builds on them, list them in Depends on.
|
8 of 9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
On Windows, SDL's DirectInput joystick enumeration blocks forever on machines with some vendor HID devices, so
SDL_InitSubSystem(VIDEO | GAMECONTROLLER)in theVideoOutDriverconstructor never returns andsceVideoOutOpenhangs. The constructor now setsSDL_HINT_DIRECTINPUT_ENABLEDto0atSDL_HINT_DEFAULTpriority before that call, so theSDL_DIRECTINPUT_ENABLEDenvironment variable still overrides it. XInput and HIDAPI controllers are still detected; controllers reachable only through DirectInput are not, recorded in the libSceVideoOut technical debt.Relands #1050 by @Tenith01 (their commit is kept as is, with the technical debt entry added as a second commit crediting them as co-author).
Fixes #1042
Tested
sceVideoOutOpenreturn andguest_video_out_wqhd_detectionpass, while the unpatched build hangs (Windows: SDL DirectInput enumeration in sceVideoOutOpen blocks forever on a HID device, so video out never opens #1042 (comment)).BUILD_TESTING=ON: builds; the change is compiled only on Windows.tools/check_conventions.py --base origin/mainpasses.Checklist
main; no other open PR implements the same functionsNotImplemented_nid_no_patch); silent stubs are listed under Silent stubs in their library's technical debt file.mdfiles or images added to the repository (attach them to this PR)Based on main feddf7f.